Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace deprecated usage Issue#4175 #4273

Closed
wants to merge 11 commits into from

Conversation

lilacyl
Copy link

@lilacyl lilacyl commented Nov 8, 2023

Which problem is this PR solving?

Working on Issue #4175 in the package experimental/packages/opentelemetry-exporter-prometheus/

Fixes #4175

Short description of the changes

Replace usages of MetricAttributes with Attributes

Type of change

chore

legendecas and others added 11 commits November 1, 2023 19:51
* chore: track package-lock.json

* Pin to old versions for node 14

* Use version range

* Remove unused cached directories

* Temporarily disable other tests

* Temporarily enable only api test

* Enable only some packages

* Test only api packages

* Test trace exporters

* Fix line ordering

* Test all packages except otlp exporters

* Add trace http exporter

* Add trace proto exporter

* Test all but grpc exporters

* chore: use npm workspaces and degrade lerna to v6

* chore: get rid of lerna bootstrap

* chore: use npx

* chore: allow install scripts to setup buf

* chore: fix w3c-integration-test cache key

* chore: fix cache key

* chore: disable resource compat test

* chore: fix node_modules assumptions

* chore: fix hoisted karma issue

* chore: fix markdown linter complaints

* chore: lock @grpc/grpc-js to v1.8.21

* Break caches

* chore: remove cache

* chore: fixup inline commands

---------

Co-authored-by: Daniel Dyla <[email protected]>
@lilacyl lilacyl requested a review from a team November 8, 2023 22:32
Copy link

CLA Not Signed

@lilacyl lilacyl changed the title chore: replace deprecated usage #4175 chore: replace deprecated usage Issue#4175 Nov 8, 2023
@hectorhdzg
Copy link
Member

@lilacyl looks like you have some merge issues here, there are tons of unrelated changes. It may be good to sync your fork

@dyladan dyladan linked an issue Dec 1, 2023 that may be closed by this pull request
@dyladan
Copy link
Member

dyladan commented Dec 1, 2023

@lilacyl are you still working on this or should someone else pick it up?

Copy link

github-actions bot commented Jan 1, 2024

This PR was closed because it has been stale for 14 days with no activity.

@github-actions github-actions bot closed this Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace usages of SpanAttributes/MetricAttributes with Attributes
10 participants