Instrument gRPC server span status codes #1127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damemi
force-pushed
the
grpc-server-status-code
branch
from
c273d22
to
637da87
Compare
damemi
force-pushed
the
grpc-server-status-code
branch
from
637da87
to
0863a1e
Compare
MrAlias
approved these changes
Sep 25, 2024
internal/pkg/instrumentation/bpf/google.golang.org/grpc/server/bpf/probe.bpf.c
Outdated
Show resolved
Hide resolved
…/bpf/probe.bpf.c Co-authored-by: Tyler Yahn <[email protected]>
RonFed
reviewed
Sep 27, 2024
| void *stream_ptr = get_argument(ctx, 2); | ||
| u32 stream_id = 0; | ||
| bpf_probe_read(&stream_id, sizeof(stream_id), (void *)(stream_ptr + stream_id_pos)); | ||
| struct grpc_request_t *grpcReq = bpf_map_lookup_elem(&streamid_to_grpc_events, &stream_id); |
There was a problem hiding this comment.
I think it might be better to look here at the grpc_events map.
If I understand this correctly, this probe should be called between the entry probe of handleStream (where an entry is created for the stream in the grpc_events map) and the return probe of handleStream.
If we can't find an entry it means the entry probe didn't run properly or didn't run at all, hence in that case we won't have a valid start time. WDYT?
RonFed
reviewed
Sep 27, 2024
Comment on lines
+86
to
+93
| { | ||
| Sym: "google.golang.org/grpc/internal/transport.(*serverHandlerTransport).WriteStatus", | ||
| EntryProbe: "uprobe_serverHandlerTransport_WriteStatus", | ||
| }, | ||
| { | ||
| Sym: "google.golang.org/grpc/internal/transport.(*http2Server).WriteStatus", | ||
| EntryProbe: "uprobe_http2Server_WriteStatus", | ||
| }, |
There was a problem hiding this comment.
Are we instrumenting both of them because either of them might be used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #172