Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk-metrics] Improve exemplar tests #5393

Merged

Conversation

CodeBlanch
Copy link
Member

[Originally part of #5364]

Changes

  • Adds internal ExemplarReservoir factory on view API.
  • Use the view API to test delta/cumulative temporality behaviors in exemplar tests.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated

@CodeBlanch CodeBlanch added pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package metrics Metrics signal related labels Feb 27, 2024
@CodeBlanch CodeBlanch requested a review from a team February 27, 2024 20:08
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 90.32258% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 83.14%. Comparing base (6250307) to head (6f3070a).
Report is 101 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5393      +/-   ##
==========================================
- Coverage   83.38%   83.14%   -0.25%     
==========================================
  Files         297      284      -13     
  Lines       12531    12070     -461     
==========================================
- Hits        10449    10035     -414     
+ Misses       2082     2035      -47     
Flag Coverage Δ
unittests ?
unittests-Solution-Experimental 83.11% <90.32%> (?)
unittests-Solution-Stable 83.12% <90.32%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/OpenTelemetry/Metrics/AggregatorStore.cs 80.48% <100.00%> (+0.09%) ⬆️
src/OpenTelemetry/Metrics/Metric.cs 96.77% <100.00%> (+0.25%) ⬆️
src/OpenTelemetry/Metrics/MetricReaderExt.cs 91.50% <100.00%> (+1.50%) ⬆️
...OpenTelemetry/Metrics/MetricStreamConfiguration.cs 80.76% <100.00%> (+5.76%) ⬆️
src/OpenTelemetry/Metrics/MetricPoint.cs 66.60% <62.50%> (-1.88%) ⬇️

... and 52 files with indirect coverage changes

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks for the cumulative testing targeting the spec question! open-telemetry/opentelemetry-specification#3891
Very helpful.

@CodeBlanch CodeBlanch merged commit e7cbbbb into open-telemetry:main Feb 27, 2024
37 checks passed
@CodeBlanch CodeBlanch deleted the sdk-exemplar-test-improvements branch February 27, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metrics Metrics signal related pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants