[chore][CONTRIBUTING.md] Move coding guidelines to separate document #11484
+442
−439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
force-pushed
the
mx-psi/split-off-coding-guidelines
branch
from
d5aa619
to
d2a433c
Compare
|
@atoulme I want to work on improving the coding guidelines (specifically, making naming conventions clearer as we have discussed offline a couple times). This is the very first step, moving them to a separate doc since CONTRIBUTING.md was getting a bit too big. Can you take a look? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11484 +/- ##
=======================================
Coverage 91.48% 91.48%
=======================================
Files 433 433
Lines 23617 23617
=======================================
Hits 21607 21607
Misses 1642 1642
Partials 368 368 ☔ View full report in Codecov by Sentry. |
bogdandrutu
approved these changes
Oct 18, 2024
codeboten
approved these changes
Oct 18, 2024
songy23
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves coding guidelines to a separate document where we can work on expanding them. This is the largest part of the contributing document and it was making it a bit difficult to work with and scary-looking for newcomers.