Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profiles support to OTLP exporter #11435

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Oct 14, 2024

Description

This uses the profiles internal packages that were implemented in previous PRs to provide profiles support to the OTLP exporter.

This PR requires #11226✅ to be merged first.

@dmathieu dmathieu changed the title Profilesexporter Add profiles support to OTLP exporter Oct 14, 2024
@dmathieu dmathieu force-pushed the profilesexporter branch 5 times, most recently from 7e44499 to fbe7524 Compare October 14, 2024 09:25
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.48%. Comparing base (f330cfb) to head (688f9c0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
exporter/otlpexporter/otlp.go 80.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11435      +/-   ##
==========================================
- Coverage   91.49%   91.48%   -0.01%     
==========================================
  Files         433      433              
  Lines       23588    23617      +29     
==========================================
+ Hits        21581    21607      +26     
- Misses       1640     1642       +2     
- Partials      367      368       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi
Copy link
Member

mx-psi commented Oct 16, 2024

I merged #11226 :)

@dmathieu dmathieu marked this pull request as ready for review October 16, 2024 11:35
@dmathieu dmathieu requested a review from a team as a code owner October 16, 2024 11:35
@dmathieu dmathieu requested a review from songy23 October 16, 2024 11:35
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @open-telemetry/collector-approvers I will merge this on Friday EU morning unless there are comments before then

@mx-psi
Copy link
Member

mx-psi commented Oct 18, 2024

@dmathieu Can you fix the merge conflict?

@dmathieu
Copy link
Member Author

Done!

@mx-psi mx-psi merged commit 68e1000 into open-telemetry:main Oct 18, 2024
48 of 49 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 18, 2024
@dmathieu dmathieu deleted the profilesexporter branch October 18, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants