Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint errors #11423

Conversation

bogdandrutu
Copy link
Member

Fix lots of tests, for non-tests add nolint annotations when fix not trivial.

Signed-off-by: Bogdan Drutu <[email protected]>
@bogdandrutu bogdandrutu requested a review from a team as a code owner October 12, 2024 22:48
@bogdandrutu bogdandrutu requested review from mx-psi and removed request for a team October 12, 2024 22:48
@bogdandrutu bogdandrutu merged commit b405a8a into open-telemetry:renovate/github.com-golangci-golangci-lint-1.x Oct 12, 2024
@bogdandrutu bogdandrutu deleted the fixlints branch October 12, 2024 22:48
@github-actions github-actions bot added this to the next release milestone Oct 12, 2024
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.15%. Comparing base (c38745c) to head (30568a9).
Report is 2 commits behind head on renovate/github.com-golangci-golangci-lint-1.x.

Additional details and impacted files
@@                               Coverage Diff                               @@
##           renovate/github.com-golangci-golangci-lint-1.x   #11423   +/-   ##
===============================================================================
  Coverage                                           92.14%   92.15%           
===============================================================================
  Files                                                 432      432           
  Lines                                               20296    20255   -41     
===============================================================================
- Hits                                                18702    18666   -36     
+ Misses                                               1231     1228    -3     
+ Partials                                              363      361    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant