Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] [DO NOT MERGE] Entities support prototype #11282

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Sep 27, 2024

Updated version of tigrannajaryan#4

Additional changes:

  • Resource now has additional slice fields to reference attributes for the entity that this resource represents.
  • EntitiesData now includes a resource that represents a parent entity. It allows all entities in the EntitiesData message to have local identities in the context of the parent entity.
  • Full support of entities pipeline
  • Components with entities support:
    • otlp receiver
    • memory_limiter processor
    • debug exporter

@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 84.19453% with 104 lines in your changes missing coverage. Please review.

Project coverage is 91.92%. Comparing base (4dbbb90) to head (e503672).

Files with missing lines Patch % Lines
pdata/pentity/entities.go 0.00% 24 Missing ⚠️
pdata/internal/wrapper_entities.go 0.00% 16 Missing ⚠️
receiver/receiver.go 0.00% 11 Missing ⚠️
consumer/entities.go 0.00% 9 Missing ⚠️
pdata/pentity/event_type.go 0.00% 9 Missing ⚠️
...rter/debugexporter/internal/otlptext/databuffer.go 27.27% 8 Missing ⚠️
exporter/exporter.go 27.27% 8 Missing ⚠️
processor/processor.go 27.27% 8 Missing ⚠️
cmd/mdatagen/internal/validate.go 33.33% 4 Missing and 2 partials ⚠️
pdata/pentity/generated_entityevent.go 93.22% 2 Missing and 2 partials ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11282      +/-   ##
==========================================
- Coverage   92.14%   91.92%   -0.22%     
==========================================
  Files         433      452      +19     
  Lines       20389    21044     +655     
==========================================
+ Hits        18787    19345     +558     
- Misses       1238     1331      +93     
- Partials      364      368       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmitryax dmitryax force-pushed the entities-support-prototype branch 4 times, most recently from 65b238e to e7ca00d Compare October 2, 2024 04:58
@dmitryax dmitryax force-pushed the entities-support-prototype branch 2 times, most recently from d15292c to 4a367ad Compare October 2, 2024 17:18
@dmitryax dmitryax force-pushed the entities-support-prototype branch 2 times, most recently from 1e6eae7 to 2df8d84 Compare October 16, 2024 22:40
@dmitryax dmitryax force-pushed the entities-support-prototype branch 2 times, most recently from 7f32778 to e503672 Compare October 16, 2024 23:36
dmitryax added a commit that referenced this pull request Oct 18, 2024
Currently, pdatagen doesn't allow defining slices in the common package,
while all other types do allow it. This is needed for
#11282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants