Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fleet-level task #201

Merged
merged 6 commits into from
Jan 26, 2024

Conversation

cwrx777
Copy link
Contributor

@cwrx777 cwrx777 commented Jan 10, 2024

Update scripts to specify fleet_name in task requests.
This PR depends on:

@cwrx777 cwrx777 force-pushed the charlywrx/support_fleet_task branch from 29d336f to 3b21058 Compare January 11, 2024 13:54
Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you format your code to satisfy the linter?

@Yadunund
Copy link
Member

@cwrx777 suggest to run pycodestyle locally and satisfy all errors before pushing

Run pycodestyle .
  pycodestyle .
  shell: bash --noprofile --norc -e -o pipefail {0}
./rmf_demos_tasks/rmf_demos_tasks/dispatch_teleop.py:42:6[1](https://github.com/open-rmf/rmf_demos/actions/runs/7537115867/job/20515694103?pr=201#step:5:1): W[2](https://github.com/open-rmf/rmf_demos/actions/runs/7537115867/job/20515694103?pr=201#step:5:2)91 trailing whitespace
./rmf_demos_tasks/rmf_demos_tasks/dispatch_teleop.py:[4](https://github.com/open-rmf/rmf_demos/actions/runs/7537115867/job/20515694103?pr=201#step:5:5)4:61: W291 trailing whitespace

Yadunund
Yadunund previously approved these changes Jan 16, 2024
@Yadunund
Copy link
Member

@cwrx777 can you make sure all your commits are signed? https://docs.github.com/articles/about-gpg/

@cwrx777 cwrx777 force-pushed the charlywrx/support_fleet_task branch 2 times, most recently from 14f6b35 to ec30d77 Compare January 26, 2024 01:47
@Yadunund Yadunund merged commit 9f23005 into open-rmf:main Jan 26, 2024
3 checks passed
@Yadunund Yadunund deleted the charlywrx/support_fleet_task branch January 26, 2024 07:47
Yadunund added a commit that referenced this pull request Jan 29, 2024
* update task request to include fleet_name for fleet-level task

Signed-off-by: Charly Wu <[email protected]>

* added DCO commit.

Signed-off-by: Charly Wu <[email protected]>

* simplify logic for populating request['fleet_name']

Signed-off-by: Charly Wu <[email protected]>

* remove extra whitespaces.

Signed-off-by: Charly Wu <[email protected]>

* remove trailing whitespace.

Signed-off-by: Charly Wu <[email protected]>

---------

Signed-off-by: Charly Wu <[email protected]>
Co-authored-by: Yadunund <[email protected]>
@Yadunund Yadunund mentioned this pull request Jan 29, 2024
Yadunund added a commit that referenced this pull request Jan 29, 2024
* Support fleet-level task (#201)

* update task request to include fleet_name for fleet-level task

Signed-off-by: Charly Wu <[email protected]>

* added DCO commit.

Signed-off-by: Charly Wu <[email protected]>

* simplify logic for populating request['fleet_name']

Signed-off-by: Charly Wu <[email protected]>

* remove extra whitespaces.

Signed-off-by: Charly Wu <[email protected]>

* remove trailing whitespace.

Signed-off-by: Charly Wu <[email protected]>

---------

Signed-off-by: Charly Wu <[email protected]>
Co-authored-by: Yadunund <[email protected]>

* Update CI to rolling on main (#208)

* Update CI to rolling

Signed-off-by: Yadunund <[email protected]>

* Address all flake8 and pep257 errors

Signed-off-by: Yadunund <[email protected]>

---------

Signed-off-by: Yadunund <[email protected]>

* Set CI to iron

Signed-off-by: Yadunund <[email protected]>

---------

Signed-off-by: Charly Wu <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Co-authored-by: cwrx777 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants