Fix suse gcov #825
Merged
Fix suse gcov #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Praveen K Pandey <[email protected]>
PraveenPenguin
force-pushed
the
fix_suse_gcov
branch
from
5413368
to
a18e88b
Compare
abdhaleegit
requested changes
Apr 19, 2024
testcases/GcovSetup.py
Outdated
| log.info("\nInstalling the ditro src...") | ||
| if self.distro_name == 'rhel': | ||
| src_path = self.util.get_distro_src('kernel', '/root', "-bp") | ||
| elif self.distro_name == 'sles': | ||
| src_path = self.util.get_distro_src('kernel-default', '/root', "-bp") | ||
| src_path = self.util.get_distro_src('kernel-default', '/root', "-bp", "linux") | ||
| distro = "sles" |
There was a problem hiding this comment.
why not make distro a class variable, so this will expand the scope into all methods.. and you no need to pass distro as extra parameter in each of these function self.kernel_config(src_path, distro) self.add_gcov_param(src_conf_file, distro)
There was a problem hiding this comment.
yes good idea
Signed-off-by: Praveen K Pandey <[email protected]>
PraveenPenguin
force-pushed
the
fix_suse_gcov
branch
from
a18e88b
to
16e87ec
Compare
|
@abdhaleegit taken care review comment , can you please have a look |
abdhaleegit
reviewed
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1- [Fixed Support for Suse source package can be get via API]
2- [added support in get kernel source in suse case]