Use SHA256 instead of SHA1 for ipmi server connection algorithm #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using ipmitool, the default server encryption algorithm for lanplus connections use SHA1. openBMC has dropped support for SHA1. This will result in ipmi connection errors due to "invalid authentication algorithm". Fortunately, a more trusted algorithm, like SHA256, can be used with the ipmitool option `-C <ciphersuite>`. This commit uses `-C 17` in all ipmitool commands to ensure that SHA256 is used instead of the deprecated SHA1. Signed-off-by: Nick Child <[email protected]>
PraveenPenguin
force-pushed
the
master
branch
2 times, most recently
from
4d0cb14
to
b976629
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I was having trouble running tests due to all
ipmitoolcommands returning "invalid authentication algorithm". Apparently,ipmitooldefaults to algorithms that use SHA1. It seems that openBMC has recently stopped supporting SHA1 . I was able to fix my issue by using-C 17(AES with HMAC-SHA256) in myipmitoolcommands. I figure it is worth implementing across allipmitoolcommands since I cannot think of anyone who would rather use a different cipher-suite. If I am wrong, then I can work on making it a config option. Until then, I propose using HMAC-SHA256 for all ipmi connections. It looks likeipmitoolwill be changing their behavior in the coming release. In the meantime, I believe this issue will persist as more BMC's are updated to drop support for SHA1.Please let me know if there is anything I am missing or if I should take any further actions.
Thanks!