Remove timestamp prefixes from logfile #569
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already put them in a timestamped directory. There's not much point in repeating it on the individual log files and as the logs are rotated the timestamps drift which makes then annoying to tab complete. If someone really wants to keep the timestamps then we could change the prefix to a suffix I guess. Signed-off-by: Oliver O'Halloran <[email protected]>
debmc
reviewed
Dec 12, 2019
There was a problem hiding this comment.
I'm not working on op-test any longer, but the only comment I have about this is I would leave as-is.
When CI runs and many logs are dumped per CI grouping, it is quite helpful to have the files reflect in general when the test was started, etc. so if comparisons are made, etc.
PraveenPenguin
force-pushed
the
master
branch
2 times, most recently
from
4d0cb14
to
b976629
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already put them in a timestamped directory. There's not much point
in repeating it on the individual log files and as the logs are rotated
the timestamps drift which makes then annoying to tab complete.
If someone really wants to keep the timestamps then we could change the
prefix to a suffix I guess.
Old:
$ ls -1 test-reports/latest/*
test-reports/latest/20191212080156693511.main.log
test-reports/latest/20191212080156693830.debug.log
test-reports/latest/20191212190156.log
test-reports/latest/op-test-esel.Thu_Dec_12_19:02:51_2019
New:
$ ls -1 test-reports/latest/*
test-reports/latest/debug.log
test-reports/latest/host-console.log
test-reports/latest/main.log
test-reports/latest/op-test-esel.Thu_Dec_12_18:43:12_2019
Signed-off-by: Oliver O'Halloran [email protected]