romio,hwloc: fix type errors for x86 #12735
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the most egregious type violations that not only prevent with GCC 14 on i586 but that are just bugs too. Signed-off-by: Nicolas Morey <[email protected]>
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: ebf1601: romio,hwloc: fix type errors for x86
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
jsquyres
requested changes
Aug 12, 2024
| @@ -48,7 +48,7 @@ static bool external_topology = false; | |||
|
|
|||
| #if HWLOC_API_VERSION >= 0x20000 | |||
| static size_t shmemsize = 0; | |||
| static size_t shmemaddr; | |||
| static uintptr_t shmemaddr; | |||
There was a problem hiding this comment.
It looks like this value is serialized as a size_t down below. Can you investigate? I don't know where the corresponding deserialization occurs -- you might need to chase that down, too.
I didn't check further to see how the other variables that were converted to uintptr_t are used; those might need to be updated in their usage, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the most egregious type violations that not only prevent with GCC 14 on i586 but that are just bugs too.