Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: salesforce table description from label if not through query #18286

Merged
merged 1 commit into from
Oct 16, 2024
Merged

MINOR: salesforce table description from label if not through query #18286

merged 1 commit into from
Oct 16, 2024

Conversation

harshsoni2024
Copy link
Contributor

@harshsoni2024 harshsoni2024 commented Oct 16, 2024 •
edited
Loading

Describe your changes:

Fixes: We are using query to get description in salesforce tables.

"query/?q=SELECT+Description+FROM+EntityDefinition+WHERE+QualifiedApiName='{table_name}'"

In many cases it's not able to get description from this(possible in free tier version), so we can get that from table/describe API.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@harshsoni2024 harshsoni2024 requested a review from a team as a code owner October 16, 2024 05:29
@harshsoni2024 harshsoni2024 added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Oct 16, 2024
@notion-workspace Notion Workspace
Copy link

salesforce table description issue

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 16, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
20.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@harshsoni2024 harshsoni2024 merged commit 4f89dc5 into open-metadata:main Oct 16, 2024
22 of 32 checks passed
harshsoni2024 added a commit that referenced this pull request Oct 16, 2024
@harshsoni2024
salesforce table description from label if not through query (#18286)
4ac6111
harshach pushed a commit that referenced this pull request Oct 17, 2024
@harshsoni2024 @harshach
salesforce table description from label if not through query (#18286)
74bb8ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbrull pmbrull pmbrull approved these changes

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshsoni2024 @pmbrull