Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEN-1662 : Fix - on dashboard soft delete, chart should not be visible in search #18283

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

sonika-shah
Copy link
Contributor

Describe your changes:

Fix if Dashboard is soft deleted, the charts of that dashboard shouldn't be visible in search.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link

sonarcloud bot commented Oct 16, 2024

@harshach harshach merged commit f366827 into main Oct 16, 2024
19 of 23 checks passed
@harshach harshach deleted the GEN-1662 branch October 16, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants