Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR - added test case results to search reindex #18277

Merged

Conversation

TeddyCr
Copy link
Contributor

@TeddyCr TeddyCr commented Oct 15, 2024

Describe your changes:

  • Added test case results reindex to the search index application:
    • NOTE: we'll process entity time series at the end keeping critical entities at the beginning as, for example, test case result reindex could take more time.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Improvement

  • I have added tests around the new logic.
  • For connector/ingestion changes: I updated the documentation.

harshach
harshach previously approved these changes Oct 15, 2024
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
64.13% (37840/59002) 40.87% (15095/36937) 42.92% (4553/10608)

Copy link

sonarcloud bot commented Oct 16, 2024

Copy link

sonarcloud bot commented Oct 17, 2024

@TeddyCr TeddyCr merged commit d20ee5c into open-metadata:main Oct 17, 2024
26 of 27 checks passed
harshach pushed a commit that referenced this pull request Oct 17, 2024
* feat: added test case results to search reindex

* fix: failing typescript test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants