Add roles to tags and classification #18245

harshach · 2024-10-13T16:56:29Z

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

Checklist:

I have read the CONTRIBUTING document.
My PR title is Fixes <issue-number>: <short explanation>
I have commented on my code, particularly in hard-to-understand areas.
For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

github-actions · 2024-10-13T16:58:45Z

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

* added check to append reserve-sidebar class to body * added application value as dependency to re-run in case application refetch * fix the unit test

* fix import issue * fix: added origin entity FQN to test case index * feat: added aggregation support for bucket selector * feat: moved aggregation builder to its own class * style: ran java linting * fix: typos * style: ran java linting * feat: implement aggregation builder graph * feat: clean up existing aggregation implementation for graph builder * style: ran java linting * fix: clean up comment * style: fix java linting --------- Co-authored-by: Chirag Madlani <[email protected]>

…w connection type (#18100)

* GEN-1322: API Entity - Remove Beta * minor: add doc for the metadata pipeline * api service refactor * api service refactor backend changes * add apiconnection in test service connection * pytest fix * fix java file formatting * Fix casing of REST in ApiServiceRest.spec.ts * Refactor REST to Rest in API classes * minor change * minor change * minor change * fix cashing for API to Api * add playwright test for api service ingestion * fix: playwright test --------- Co-authored-by: harshsoni2024 <[email protected]>

Co-authored-by: Prajwal Pandit <[email protected]>

* add max length validation for glossary term name * add name validation

* MINOR: open links in new tab in DataAssetsHeader * fix: make mlModelDetail.dashboard internal link

* chore(ui): pull persona as top level settings * fix tests * update breadcrumbs * add missing type * fix ui tests * fix settings router tests

) * fix activityFeed and DataInsight AUT playwright test * minor improvement

Co-authored-by: Rounak Dhillon <[email protected]>

…#18236) * update connections * MINOR - Pass timeout in test connection and return TestConnectionStep * format * comments * comments

* GEN-1166 - Improve Ingestion Workflow Error Summary * fix test * docs * comments

* fix: custom properties folder name in generation to match expected package name (i.e. customProperties -- uppercase P) * fix: allow non admin/bot to read profiler global config with the right permission * style: ran java linting * fix: custom properties import casing

* feat: added test case results to search reindex * fix: failing typescript test case

* fix: added testSuite field back to lineage response * style: fix style

* what's new in 1.5.7 doc * minor fix around indentation * Update whatsNewData.ts Update whatsNewData.ts -- remove enumWithDescriptions pointer from the list * Added improvement for table-level, export-import Added improvement for table-level, export-import --------- Co-authored-by: Ashish Gupta <[email protected]> Co-authored-by: sonika-shah <[email protected]>

* add query builder widget * locales * add unit tests * add debounce for on change

…18310) * fixed task deserialization in Airflow metadata ingestion * fixed formatting --------- Co-authored-by: Katarzyna Kałek <[email protected]>

* Minor: Search RBAC, fix condition evaluation for single policy multiple rules * Minor: Search RBAC, fix condition evaluation for single policy multiple rules * add test for complex policies * Add viewAll policy to organization --------- Co-authored-by: Mohit Yadav <[email protected]>

Co-authored-by: Katarzyna Kałek <[email protected]>

* MINOR - Return TestConnectionResult from test_connection fn * MINOR - Return TestConnectionResult from test_connection fn

* fix: live index on test suite creation * fix: make live indexing use entityInterface

…Basic, ALL (#18328)

…or a given entity type (#18248) * Minor: Add an API to list all the properties and custom properties for a given entity type * Minor: Add an API to list all the properties and custom properties for a given entity type * add custom properties * add custom properties * add custom properties

…UI (#18242) * Fix #18007: Disabled Classifications or Tags shouldn't be visible in UI * added playwright test for disabled tags should not be visible while search * replace testing tag to new generated one to avoid flakyness * added test for checking tags are re-enabling it from disabled state * fix the playwright test for the wrong column selector --------- Co-authored-by: Ashish Gupta <[email protected]>

github-actions · 2024-10-19T22:03:12Z

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Add roles to tags and classification

dfea5ae

harshach requested a review from a team as a code owner October 13, 2024 16:56

harshach marked this pull request as draft October 13, 2024 16:56

harshach had a problem deploying to test October 13, 2024 16:56 — with GitHub Actions Failure

github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs labels Oct 13, 2024

aniketkatkar97 and others added 20 commits October 19, 2024 14:57

Update docs sync workflow to push content to main branch (#18160)

f7b3584

MINOR: added check to append reserve-sidebar class to body (#18141)

244b548

* added check to append reserve-sidebar class to body * added application value as dependency to re-run in case application refetch * fix the unit test

Refactor ServiceConnectionDetails component to handle specific Airflo…

3fe0bf9

…w connection type (#18100)

Remove the collate connector links from the OSS menu.md (#18159)

75771d9

Minor: Updated pyiceberg version to 0.5.1 (#18155)

227aee6

Co-authored-by: Prajwal Pandit <[email protected]>

Image Updates for Quick Start docs (#18113)

0a368dd

Gen-882: Add max length validation for glossary term rename (#18166)

ffc25a7

* add max length validation for glossary term name * add name validation

fix: Glue Pipeline Yaml fixed (#18163)

0261caf

MINOR: open links in new tab in DataAssetsHeader (#18172)

19152f9

* MINOR: open links in new tab in DataAssetsHeader * fix: make mlModelDetail.dashboard internal link

FIX - App Extension Migration (#18176)

df87a5b

Order Apps (#18179)

fbf065f

chore(ui): move persona as top level settings (#18171)

f5989d5

* chore(ui): pull persona as top level settings * fix tests * update breadcrumbs * add missing type * fix ui tests * fix settings router tests

doc: Update GCS connector platform in storage connectors list (#18164)

829efe1

Fix #18177: Fix Hive Metastore connection issue (#18178)

070adba

Fix Redshift profiler for external tables in Redshift Spectrum (#18182)

4a515ac

PLAYWRIGHT: fix activityFeed and DataInsight AUT playwright test (#18180

8599d3a

) * fix activityFeed and DataInsight AUT playwright test * minor improvement

Docs: Data Quality link correction (#18183)

7f43b12

Docs: Suite link correction (#18189)

87fafb2

Co-authored-by: Rounak Dhillon <[email protected]>

pmbrull and others added 25 commits October 19, 2024 14:57

MINOR - Pass timeout to test connection and return TestConnectionStep (…

8f2b706

…#18236) * update connections * MINOR - Pass timeout in test connection and return TestConnectionStep * format * comments * comments

GEN-1166 - Improve Ingestion Workflow Error Summary (#18280)

2674e84

* GEN-1166 - Improve Ingestion Workflow Error Summary * fix test * docs * comments

correct negative values of the changeCount. (#18279)

901b6a9

Minor : increase MAX_AGGREGATE_SIZE in search (#18299)

67e8724

Minor : remove EnumWithDescriptions in basic.json (#18305)

4a6af36

fix: remove test case result index from all index (#18295)

6be79f7

Added Alation Conn side panel docs (#18297)

81cfd2b

MINOR - added test case results to search reindex (#18277)

d5190a2

* feat: added test case results to search reindex * fix: failing typescript test case

Docs: Glue Spark Pipeline Lineage (#18311)

e4b66a2

MINOR: added testSuite field back to lineage response (#18313)

1c744d1

* fix: added testSuite field back to lineage response * style: fix style

Add Query builder widget (#18314)

600d7cd

* add query builder widget * locales * add unit tests * add debounce for on change

FIX #18309: fixed task deserialization in Airflow metadata ingestion (#…

2bfdbe6

…18310) * fixed task deserialization in Airflow metadata ingestion * fixed formatting --------- Co-authored-by: Katarzyna Kałek <[email protected]>

feat: update version (#18259)

fb2654d

fix(ui): GEN-1690 refresh before expiry of access token (#18235)

6d182bb

fixed dashboardDataModel enum in spec (#18304)

5d90999

Co-authored-by: Katarzyna Kałek <[email protected]>

MINOR - Validate app runner init (#18316)

2f2df40

MINOR - Return TestConnectionResult from test_connection_fn (#18320)

e30a895

* MINOR - Return TestConnectionResult from test_connection fn * MINOR - Return TestConnectionResult from test_connection fn

MINOR - live index on test suite creation (#18317)

98c04e2

* fix: live index on test suite creation * fix: make live indexing use entityInterface

Fix Search RBAC, avoid processing Operations other than ViewAll, View…

4ec92aa

…Basic, ALL (#18328)

Add Tag/Classification Roles

d15558b

harshach had a problem deploying to test October 19, 2024 21:59 — with GitHub Actions Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add roles to tags and classification #18245

Add roles to tags and classification #18245

harshach commented Oct 13, 2024

github-actions bot commented Oct 13, 2024

github-actions bot commented Oct 19, 2024

Add roles to tags and classification #18245

Are you sure you want to change the base?

Add roles to tags and classification #18245

Conversation

harshach commented Oct 13, 2024

Describe your changes:

Type of change:

Checklist:

github-actions bot commented Oct 13, 2024

github-actions bot commented Oct 19, 2024