Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: fix(looker): exclude version #18237

Merged
merged 1 commit into from
Oct 11, 2024
Merged

MINOR: fix(looker): exclude version #18237

merged 1 commit into from
Oct 11, 2024

Conversation

sushi30
Copy link
Contributor

@sushi30 sushi30 commented Oct 11, 2024 •
edited
Loading

Describe your changes:

looker-open-source/sdk-codegen#1518

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@sushi30 sushi30 requested a review from a team as a code owner October 11, 2024 17:27
@sushi30 sushi30 changed the title fix(looker): exclude version MINOR: fix(looker): exclude version Oct 11, 2024
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Oct 11, 2024
@sushi30 sushi30 enabled auto-merge (squash) October 11, 2024 17:34
@sushi30 sushi30 disabled auto-merge October 11, 2024 17:35
@sushi30 sushi30 enabled auto-merge (squash) October 11, 2024 17:35
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 11, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sushi30 sushi30 merged commit 3c7f995 into main Oct 11, 2024
15 of 16 checks passed
@sushi30 sushi30 deleted the fix-looker-sdk-version branch October 11, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshach harshach harshach approved these changes

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sushi30 @harshach