fixed dbt tag name (#18273)

open-metadata · Oct 15, 2024 · e6705f2 · e6705f2
1 parent 7d91e12
commit e6705f2
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 5 deletions.
diff --git a/ingestion/src/metadata/ingestion/source/database/dbt/metadata.py b/ingestion/src/metadata/ingestion/source/database/dbt/metadata.py
@@ -288,10 +288,7 @@ def yield_dbt_tags(
                     for tag_name in dbt_tags_list
                 ]
                 yield from get_ometa_tag_and_classification(
-                    tags=[
-                        tag_label.split(fqn.FQN_SEPARATOR)[1]
-                        for tag_label in dbt_tag_labels
-                    ],
+                    tags=[fqn.split(tag_label)[1] for tag_label in dbt_tag_labels],
                     classification_name=self.tag_classification_name,
                     tag_description="dbt Tags",
                     classification_description="dbt classification",

diff --git a/ingestion/tests/unit/resources/datasets/manifest_v8.json b/ingestion/tests/unit/resources/datasets/manifest_v8.json
@@ -77,7 +77,8 @@
             },
             "tags": [
                 "model_tag_one",
-                "model_tag_two"
+                "model_tag_two",
+                "22.8.5.1"
             ],
             "refs": [
                 [

diff --git a/ingestion/tests/unit/test_dbt.py b/ingestion/tests/unit/test_dbt.py
@@ -135,6 +135,14 @@
                 state="Suggested",
                 href=None,
             ),
+            TagLabel(
+                tagFQN='dbtTags."22.8.5.1"',
+                description=None,
+                source="Classification",
+                labelType="Automated",
+                state="Suggested",
+                href=None,
+            ),
         ],
         columns=[
             Column(
@@ -426,6 +434,12 @@ def test_dbt_manifest_v8(self, get_tag_label, es_search_from_fqn, get_dbt_owner)
                 state=State.Suggested.value,
                 source=TagSource.Classification.value,
             ),
+            TagLabel(
+                tagFQN='dbtTags."22.8.5.1"',
+                labelType=LabelType.Automated.value,
+                state=State.Suggested.value,
+                source=TagSource.Classification.value,
+            ),
         ]
         self.execute_test(
             MOCK_SAMPLE_MANIFEST_V8,