Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-record VCR cassettes #4781

Merged
merged 13 commits into from
Oct 23, 2024
Merged

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Oct 22, 2024

Closes #4777 (partially)

  • Re-recorded all cassettes (except for the ones which make use of known-broken links)
  • Updated docs concerning the release flow (VCR re-recording section)
  • Updated certificate for KVK since the previous was failing (CERTIFICATE_VERIFY_FAILED)

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.57%. Comparing base (84cdb24) to head (26cb8bf).
Report is 14 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4781   +/-   ##
=======================================
  Coverage   96.57%   96.57%           
=======================================
  Files         746      746           
  Lines       25271    25271           
  Branches     3332     3332           
=======================================
  Hits        24406    24406           
  Misses        602      602           
  Partials      263      263           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaszig vaszig force-pushed the release/3.0.0-alpha.0-re-record-vcr-cassettes branch from e3ac878 to 0665151 Compare October 23, 2024 07:18
@vaszig vaszig force-pushed the release/3.0.0-alpha.0-re-record-vcr-cassettes branch 2 times, most recently from fe3292c to 53ecb98 Compare October 23, 2024 10:24
@vaszig vaszig force-pushed the release/3.0.0-alpha.0-re-record-vcr-cassettes branch from 53ecb98 to 26cb8bf Compare October 23, 2024 10:25
@vaszig vaszig merged commit 683efe7 into master Oct 23, 2024
34 checks passed
@vaszig vaszig deleted the release/3.0.0-alpha.0-re-record-vcr-cassettes branch October 23, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare release 3.0.0-alpha.0
2 participants