Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4418] Add addressNl specific mappings to Objects API registration (variables tab) #4751

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Oct 11, 2024

Closes #4418 partly

Changes

This PR handles the frontend part of the task

  • Added specific addressNL fields/mappings to the Objects API registration
  • Added stories

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@vaszig vaszig marked this pull request as draft October 11, 2024 14:19
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.56%. Comparing base (961e607) to head (1aae8d5).
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4751      +/-   ##
==========================================
- Coverage   96.56%   96.56%   -0.01%     
==========================================
  Files         746      746              
  Lines       25185    25191       +6     
  Branches     3312     3313       +1     
==========================================
+ Hits        24320    24325       +5     
- Misses        601      602       +1     
  Partials      264      264              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure out a "transform" mechanism for (AddressNL) component(s) when registering them in the Objects API
1 participant