Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/4686 email and StUF-ZDS inline form #4708

Closed

Conversation

robinmolen
Copy link
Contributor

Closes #4686

Changes

The registration forms for Email and StUF-ZDS now use React components, instead of react-json-schema-form generated forms. This allows us to share styling and keep the styling uniform across forms. These changes also improve the user experience, by providing a simular form layout/logic as the other registration inline forms.

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@robinmolen robinmolen force-pushed the feature/4686-email-and-StUF-inline-form-UX-updates branch 2 times, most recently from abcd8bc to f3292dd Compare September 25, 2024 09:06
@robinmolen robinmolen force-pushed the feature/4686-email-and-StUF-inline-form-UX-updates branch from f3292dd to 209eb3c Compare September 25, 2024 09:10
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 62.16216% with 14 lines in your changes missing coverage. Please review.

Project coverage is 96.56%. Comparing base (9709586) to head (6a5802b).
Report is 71 commits behind head on master.

Files with missing lines Patch % Lines
src/openforms/formio/migration_converters.py 17.64% 13 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4708      +/-   ##
==========================================
- Coverage   96.61%   96.56%   -0.05%     
==========================================
  Files         746      746              
  Lines       25144    25174      +30     
  Branches     3302     3310       +8     
==========================================
+ Hits        24292    24309      +17     
- Misses        589      601      +12     
- Partials      263      264       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robinmolen robinmolen closed this Oct 8, 2024
@robinmolen
Copy link
Contributor Author

Closed PR in favor of #4742

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating the email and StUF-ZDS inline forms
2 participants