Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡ [#4695] Do not fetch all IOtypen for objects API validation #4700

Merged

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Sep 24, 2024

Closes #4695

Changes

  • Do not fetch all IOtypen for objects API validation

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.56%. Comparing base (70771b7) to head (c5a3716).
Report is 12 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4700   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files         746      746           
  Lines       25164    25174   +10     
  Branches     3307     3310    +3     
=======================================
+ Hits        24299    24309   +10     
  Misses        601      601           
  Partials      264      264           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevenbal stevenbal force-pushed the issue/4695-objects-api-validation-performance branch from 8ffb25d to c5a3716 Compare September 24, 2024 11:09
stevenbal added a commit that referenced this pull request Sep 24, 2024
stevenbal added a commit that referenced this pull request Sep 24, 2024
@stevenbal stevenbal added the needs-backport Fix must be backported to stable release branch label Sep 24, 2024
@stevenbal
Copy link
Contributor Author

stevenbal commented Sep 24, 2024

2.7.x backport: #4705 (could not cherry pick, because the validation was slightly different in that branch)

Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@sergei-maertens sergei-maertens merged commit 7b20acc into master Sep 24, 2024
33 of 34 checks passed
@sergei-maertens sergei-maertens deleted the issue/4695-objects-api-validation-performance branch September 24, 2024 14:18
@sergei-maertens
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-backport Fix must be backported to stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance regression in Objects API (legacy) validation
2 participants