Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3688] Add migration to set required fields from global configuration #3870

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Feb 12, 2024

Part of #3688

For misconfigured backends (the ones without a URL and version and when no global default is configured), should we add an upgrade check?

@Viicos Viicos linked an issue Feb 12, 2024 that may be closed by this pull request
33 tasks
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6310a31) 96.34% compared to head (cc7b164) 96.34%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3870   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files         707      707           
  Lines       22188    22188           
  Branches     2547     2547           
=======================================
  Hits        21378    21378           
  Misses        565      565           
  Partials      245      245           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens
Copy link
Member

For misconfigured backends (the ones without a URL and version and when no global default is configured), should we add an upgrade check?

I don't think this makes a lot of sense - if in $current version registration configuration is broken, you don't really win anything by preventing an upgrade. It'll just stay broken, and they'll be forced to pick an object type next time they edit the form.

@sergei-maertens sergei-maertens merged commit d757130 into master Feb 13, 2024
26 checks passed
@sergei-maertens sergei-maertens deleted the feature/3688-set-from-global-conf branch February 13, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Objects API registration backend - Improve JSON content field / mapping editor
2 participants