-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#3864] Fix handling of StufBG responses with one partner #3867
Conversation
15d8b31
to
4bdf258
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3867 +/- ##
=======================================
Coverage 96.34% 96.34%
=======================================
Files 707 707
Lines 22163 22188 +25
Branches 2542 2547 +5
=======================================
+ Hits 21353 21378 +25
Misses 565 565
Partials 245 245 ☔ View full report in Codecov by Sentry. |
src/openforms/formio/components/np_family_members/tests/responses/stuf_bg_one_family_member.xml
Outdated
Show resolved
Hide resolved
src/openforms/formio/components/np_family_members/tests/test_family_members.py
Show resolved
Hide resolved
@@ -69,6 +69,7 @@ def get_values(self, bsn: str, attributes: list[str]) -> dict: | |||
response_data, | |||
process_namespaces=True, | |||
namespaces=NAMESPACE_REPLACEMENTS, | |||
force_list=["inp.heeftAlsEchtgenootPartner", "inp.heeftAlsKinderen"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😢 why is this standard like this
I really want all of this stuff out of OF/OIP and properly organized in a centralized library used by the final projects. It's crazy how many times we implement the same things over and over but in slightly different ways. |
96c49d1
to
a11b44a
Compare
a11b44a
to
6310a31
Compare
Fixes #3864
I think it would be nice to get a more robust solution for xml parsing. OIP uses https://github.com/tefra/xsdata which looks great. https://github.com/dapper91/pydantic-xml looks interesting as well