[#3864] Fix handling of StufBG responses with one partner #3867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viicos
force-pushed
the
issue/3864-array
branch
from
15d8b31
to
4bdf258
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3867 +/- ##
=======================================
Coverage 96.34% 96.34%
=======================================
Files 707 707
Lines 22163 22188 +25
Branches 2542 2547 +5
=======================================
+ Hits 21353 21378 +25
Misses 565 565
Partials 245 245 ☔ View full report in Codecov by Sentry. |
sergei-maertens
requested changes
Feb 12, 2024
src/openforms/formio/components/np_family_members/tests/responses/stuf_bg_one_family_member.xml
Outdated
Show resolved
Hide resolved
src/openforms/formio/components/np_family_members/tests/test_family_members.py
Show resolved
Hide resolved
| @@ -69,6 +69,7 @@ def get_values(self, bsn: str, attributes: list[str]) -> dict: | |||
| response_data, | |||
| process_namespaces=True, | |||
| namespaces=NAMESPACE_REPLACEMENTS, | |||
| force_list=["inp.heeftAlsEchtgenootPartner", "inp.heeftAlsKinderen"], | |||
There was a problem hiding this comment.
😢 why is this standard like this
I really want all of this stuff out of OF/OIP and properly organized in a centralized library used by the final projects. It's crazy how many times we implement the same things over and over but in slightly different ways. |
sergei-maertens
added
the
needs-backport
Viicos
force-pushed
the
issue/3864-array
branch
2 times, most recently
from
96c49d1
to
a11b44a
Compare
Viicos
force-pushed
the
issue/3864-array
branch
from
a11b44a
to
6310a31
Compare
sergei-maertens
approved these changes
Feb 12, 2024
sergei-maertens
pushed a commit
that referenced
this pull request
Feb 12, 2024
sergei-maertens
pushed a commit
that referenced
this pull request
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3864
I think it would be nice to get a more robust solution for xml parsing. OIP uses https://github.com/tefra/xsdata which looks great. https://github.com/dapper91/pydantic-xml looks interesting as well