-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#3215] Prefill with bewindvoering/machtigen #3241
[#3215] Prefill with bewindvoering/machtigen #3241
Conversation
3d93719
to
7f4609c
Compare
src/openforms/js/components/admin/form_design/variables/VariablesTable.js
Show resolved
Hide resolved
7f4609c
to
e07b4bf
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3241 +/- ##
==========================================
+ Coverage 94.87% 94.91% +0.04%
==========================================
Files 623 624 +1
Lines 19622 19672 +50
Branches 2220 2234 +14
==========================================
+ Hits 18616 18672 +56
+ Misses 716 708 -8
- Partials 290 292 +2
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the codecov messages in the plugin weird. I'd expect there would already have been tests for these codepaths.
src/openforms/authentication/contrib/digid_eherkenning_oidc/plugin.py
Outdated
Show resolved
Hide resolved
src/openforms/js/components/admin/form_design/variables/VariablesTable.js
Show resolved
Hide resolved
src/openforms/js/components/admin/form_design/variables/VariablesTable.js
Outdated
Show resolved
Hide resolved
30ca07b
to
466e840
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also use the constant/choices you defined instead of using the magic string "main"
for defaults/fallbacks?
We should also properly document in the release notes that this contains breaking changes for the prefill plugin developers, as the public API now requires additional fields (and method signatures have changed).
src/openforms/authentication/contrib/digid_eherkenning_oidc/plugin.py
Outdated
Show resolved
Hide resolved
src/openforms/authentication/contrib/digid_eherkenning_oidc/plugin.py
Outdated
Show resolved
Hide resolved
src/openforms/authentication/contrib/digid_eherkenning_oidc/plugin.py
Outdated
Show resolved
Hide resolved
src/openforms/js/components/admin/form_design/variables/VariablesTable.js
Show resolved
Hide resolved
src/openforms/js/components/admin/form_design/variables/constants.js
Outdated
Show resolved
Hide resolved
ad7761a
to
15713b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it!
Fixes #3215
Related PR in the new builder: open-formulieren/formio-builder#26