[#3215] Prefill with bewindvoering/machtigen #3241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilviaAmAm
force-pushed
the
feature/3215-eherkenning-bewinfvoering-prefill
branch
from
3d93719
to
7f4609c
Compare
SilviaAmAm
commented
Jul 10, 2023
src/openforms/js/components/admin/form_design/variables/VariablesTable.js
Show resolved
Hide resolved
SilviaAmAm
force-pushed
the
feature/3215-eherkenning-bewinfvoering-prefill
branch
from
7f4609c
to
e07b4bf
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3241 +/- ##
==========================================
+ Coverage 94.87% 94.91% +0.04%
==========================================
Files 623 624 +1
Lines 19622 19672 +50
Branches 2220 2234 +14
==========================================
+ Hits 18616 18672 +56
+ Misses 716 708 -8
- Partials 290 292 +2
☔ View full report in Codecov by Sentry. |
CharString
requested changes
Jul 11, 2023
src/openforms/authentication/contrib/digid_eherkenning_oidc/plugin.py
Outdated
Show resolved
Hide resolved
src/openforms/js/components/admin/form_design/variables/VariablesTable.js
Show resolved
Hide resolved
src/openforms/js/components/admin/form_design/variables/VariablesTable.js
Outdated
Show resolved
Hide resolved
SilviaAmAm
force-pushed
the
feature/3215-eherkenning-bewinfvoering-prefill
branch
from
30ca07b
to
466e840
Compare
There was a problem hiding this comment.
Can you also use the constant/choices you defined instead of using the magic string "main" for defaults/fallbacks?
We should also properly document in the release notes that this contains breaking changes for the prefill plugin developers, as the public API now requires additional fields (and method signatures have changed).
src/openforms/authentication/contrib/digid_eherkenning_oidc/plugin.py
Outdated
Show resolved
Hide resolved
src/openforms/authentication/contrib/digid_eherkenning_oidc/plugin.py
Outdated
Show resolved
Hide resolved
src/openforms/authentication/contrib/digid_eherkenning_oidc/plugin.py
Outdated
Show resolved
Hide resolved
src/openforms/js/components/admin/form_design/variables/VariablesTable.js
Show resolved
Hide resolved
src/openforms/js/components/admin/form_design/variables/constants.js
Outdated
Show resolved
Hide resolved
SilviaAmAm
force-pushed
the
feature/3215-eherkenning-bewinfvoering-prefill
branch
from
ad7761a
to
15713b4
Compare
sergei-maertens
deleted the
feature/3215-eherkenning-bewinfvoering-prefill
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3215
Related PR in the new builder: open-formulieren/formio-builder#26