Android NFC signing #523
Merged
Android NFC signing #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raul Metsma <[email protected]>
Signed-off-by: Lauris Kaplinski <[email protected]>
Signed-off-by: Lauris Kaplinski <[email protected]>
Signed-off-by: Lauris Kaplinski <[email protected]>
Co-authored-by: Raul Metsma <[email protected]>
…ents Signed-off-by: Lauris Kaplinski <[email protected]>
…ereference Signed-off-by: Lauris Kaplinski <[email protected]>
Fix NFC accessibility
Squashed commits: [548e2dd] Fixed some minor warnings about unused variables and potential null dereference Signed-off-by: Lauris Kaplinski <[email protected]> (+1 squashed commit) Squashed commits: [46ea501] Removed commented out code and reverted some AndroidStudio rearrangements Signed-off-by: Lauris Kaplinski <[email protected]> (+1 squashed commit) Squashed commits: [87e91ca] Update app/src/main/java/ee/ria/DigiDoc/android/Activity.java Co-authored-by: Raul Metsma <[email protected]> (+1 squashed commit) Squashed commits: [45df8a0] Some minor accessibility fixes Signed-off-by: Lauris Kaplinski <[email protected]>
Signed-off-by: Lauris Kaplinski <[email protected]>
Signed-off-by: Lauris Kaplinski <[email protected]> # Conflicts: # app/src/main/java/ee/ria/DigiDoc/android/signature/update/nfc/NFCOnSubscribe.java
Signed-off-by: Lauris Kaplinski <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| public final int start; | ||
| public final int end; | ||
|
|
||
| public TLV(byte[] data, int start, int end) throws NFCException { |
Check notice
Code scanning / CodeQL
Useless parameter
| private byte[] decryptNonce(byte[] encryptedNonce, byte[] CAN) throws NoSuchPaddingException, InvalidKeyException, NoSuchAlgorithmException, IllegalBlockSizeException, BadPaddingException, InvalidAlgorithmParameterException { | ||
| byte[] decryptionKey = createKey(CAN, (byte) 3); | ||
| Cipher cipher = Cipher.getInstance("AES/CBC/NoPadding"); | ||
| cipher.init(Cipher.DECRYPT_MODE, new SecretKeySpec(decryptionKey, "AES"), new IvParameterSpec(new byte[16])); |
Check failure
Code scanning / CodeQL
Using a static initialization vector for encryption
|
|
||
| private byte[] encryptDecryptData(byte[] data, int mode) throws NoSuchPaddingException, NoSuchAlgorithmException, InvalidKeyException, BadPaddingException, IllegalBlockSizeException, InvalidAlgorithmParameterException { | ||
| SecretKeySpec secretKeySpec = new SecretKeySpec(keyEnc, "AES"); | ||
| Cipher cipher = Cipher.getInstance("AES/ECB/PKCS5Padding"); |
Check failure
Code scanning / CodeQL
Use of a broken or risky cryptographic algorithm
Improve NFC design
NFC length checking fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MOPPAND-1170
Signed-off-by: Firstname Lastname [email protected]