Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add update-csv when make update #238

Conversation

xuezhaojun
Copy link
Member

@xuezhaojun xuezhaojun commented Jul 26, 2023

Summary

This is a issue when I tried to update Kluterlet in this PR: #234

We run make update to use the latest version of Klusterlet, but then the integration-test fails because it depends on the following file:

filepath.Join(".", "deploy", "klusterlet", "olm-catalog", "klusterlet", "manifests"),

And this file needs to update by the make update-csv command.

So it's better to combine 2 commands.

@xuezhaojun
Copy link
Member Author

/assign @qiujian16

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage: 83.90% and project coverage change: +0.01% 🎉

Comparison is base (e22faa4) 60.29% compared to head (e04cb4b) 60.31%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
+ Coverage   60.29%   60.31%   +0.01%     
==========================================
  Files         131      131              
  Lines       13543    13538       -5     
==========================================
- Hits         8166     8165       -1     
+ Misses       4625     4621       -4     
  Partials      752      752              
Flag Coverage Δ
unit 60.31% <83.90%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/common/options/agent.go 66.66% <ø> (ø)
pkg/common/options/options.go 100.00% <ø> (ø)
...llers/crdstatuccontroller/crd_status_controller.go 37.31% <ø> (ø)
...sterletcontroller/klusterlet_cleanup_controller.go 55.10% <ø> (ø)
...llers/ssarcontroller/klusterlet_ssar_controller.go 76.98% <ø> (-0.07%) ⬇️
...nt/controllers/scheduling/cluster_event_handler.go 59.25% <ø> (ø)
pkg/placement/debugger/debugger.go 52.63% <ø> (ø)
pkg/registration/clientcert/cert_controller.go 44.39% <ø> (ø)
pkg/registration/clientcert/certificate.go 42.61% <ø> (+1.70%) ⬆️
...stration/spoke/managedcluster/status_controller.go 53.06% <ø> (ø)
... and 35 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xuezhaojun
Copy link
Member Author

/retest

@qiujian16
Copy link
Member

/approve
/lgtm

would you also add a TODO to verify the csv?

@openshift-ci openshift-ci bot added the lgtm label Jul 27, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 70d6112 into open-cluster-management-io:main Jul 27, 2023
13 checks passed
@xuezhaojun xuezhaojun deleted the add-update-csv-in-update branch July 27, 2023 01:21
@xuezhaojun
Copy link
Member Author

/approve /lgtm

would you also add a TODO to verify the csv?

Agree, I will add csv verification in the "make verify-crds" later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants