✨ Aws iam auth api change request #339
Conversation
suvaanshkumar
changed the title
|
you would need to update the types.go at first, and then run make update to generate crd and client code. Ensure to run make verify after make update. Here https://github.com/open-cluster-management-io/api/blob/main/docs/development.md has some infos. |
|
Thanks @qiujian16 for the suggestions. Please take a look at the updated changes with required changes. |
operator/v1/types_klusterlet.go
Outdated
|
|
||
| // Contain the details required for registering with eks hub cluster using IAM roles for service account. | ||
| // This is required only when the authType is awsirsa. | ||
| AwsIrsa AwsIrsa `json:"awsIrsa,omitempty"` |
operator/v1/types_klusterlet.go
Outdated
| // The arn of the EKS hub cluster. This will be required to pass information to hub, which hub will use to create IAM identities for this klusterlet. | ||
| // Example - arn:eks:us-west-2:12345678910:cluster/hub-cluster1. | ||
| // +required | ||
| EksHubClusterArn string `json:"eksHubClusterArn"` |
operator/v1/types_klusterlet.go
Outdated
| } | ||
|
|
||
| type AwsIrsa struct { | ||
| // The arn of the EKS hub cluster. This will be required to pass information to hub, which hub will use to create IAM identities for this klusterlet. |
There was a problem hiding this comment.
@qiujian16 do we still need to mention EKS here specifically after your field rename suggestion? Should we do something like: "The arn of the hub cluster (ie: an EKS cluster)."
There was a problem hiding this comment.
This arn is specific to the EKS cluster only. I can update the description to The arn of the hub cluster (ie: an EKS cluster).
operator/v1/types_klusterlet.go
Outdated
| // +kubebuilder:validation:Enum=csr;awsirsa | ||
| AuthType string `json:"authType"` | ||
|
|
||
| // Contain the details required for registering with eks hub cluster using IAM roles for service account. |
There was a problem hiding this comment.
| // Contain the details required for registering with eks hub cluster using IAM roles for service account. | |
| // Contain the details required for registering with hub cluster (ie: an EKS cluster) using AWS IAM roles for service account. |
I think it's better to be consistent and use EKS in upper case in all the places.
Signed-off-by: Erica <[email protected]>
EricaJ6
force-pushed
the
AWS-IAM-Auth_API-change_request
branch
from
168d77a
to
912d545
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, suvaanshkumar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
|
/lgtm |
openshift-merge-bot
bot
merged commit a19871c
into
open-cluster-management-io:main
Summary
Related issue(s)
Fixes #