Merge pull request cBioPortal#4803 from TJMKuijpers/sv-add-p-value

Default visibility of p-value above legend SV plot
onursumer · Jan 5, 2024 · f8eddaf · f8eddaf
2 parents 7b13542 + 824daa4
commit f8eddaf
Show file tree

Hide file tree

Showing 12 changed files with 6 additions and 11 deletions.
diff --git a/...al_chart_with_hazard_ratio_table_and_landmark_line_element_chrome_1600x1000.png b/...al_chart_with_hazard_ratio_table_and_landmark_line_element_chrome_1600x1000.png
diff --git a/...s/reference/survival_chart_with_hazard_ratio_table_element_chrome_1600x1000.png b/...s/reference/survival_chart_with_hazard_ratio_table_element_chrome_1600x1000.png
diff --git a/...hart_with_landmark_event_and_hazard_ratio_disabled_element_chrome_1600x1000.png b/...hart_with_landmark_event_and_hazard_ratio_disabled_element_chrome_1600x1000.png
diff --git a/...urvival_chart_with_landmark_event_at_time_point_20_element_chrome_1600x1000.png b/...urvival_chart_with_landmark_event_at_time_point_20_element_chrome_1600x1000.png
diff --git a/...eference/excluding_unprofiled_samples_survival_tab_element_chrome_1600x1000.png b/...eference/excluding_unprofiled_samples_survival_tab_element_chrome_1600x1000.png
diff --git a/...ison_page_survival_tab_exclude_overlapping_samples_element_chrome_1600x1000.png b/...ison_page_survival_tab_exclude_overlapping_samples_element_chrome_1600x1000.png
diff --git a/...ison_page_survival_tab_include_overlapping_samples_element_chrome_1600x1000.png b/...ison_page_survival_tab_include_overlapping_samples_element_chrome_1600x1000.png
diff --git a/...mote/screenshots/reference/no_session_survival_tab_element_chrome_1600x1000.png b/...mote/screenshots/reference/no_session_survival_tab_element_chrome_1600x1000.png
diff --git a/...rison_tab_survival_tab_exclude_overlapping_samples_element_chrome_1600x1000.png b/...rison_tab_survival_tab_exclude_overlapping_samples_element_chrome_1600x1000.png
diff --git a/...rison_tab_survival_tab_include_overlapping_samples_element_chrome_1600x1000.png b/...rison_tab_survival_tab_include_overlapping_samples_element_chrome_1600x1000.png
diff --git a/.../remote/screenshots/reference/session_survival_tab_element_chrome_1600x1000.png b/.../remote/screenshots/reference/session_survival_tab_element_chrome_1600x1000.png
diff --git a/src/pages/resultsView/survival/SurvivalChart.tsx b/src/pages/resultsView/survival/SurvivalChart.tsx
@@ -174,8 +174,8 @@ export default class SurvivalChartExtended
             },
         },
         pValue: {
-            x: 800,
-            y: 50,
+            x: 910,
+            y: 30,
             textAnchor: 'start',
         },
         legend: {
@@ -576,11 +576,8 @@ export default class SurvivalChartExtended
     private get pValueText() {
         return (
             <VictoryLabel
-                x={this.styleOpts.width - this.styleOpts.padding.right + 10}
-                y={
-                    this.styleOpts.pValue.y +
-                    50 * this.analysisGroupsWithData.length
-                }
+                x={this.styleOpts.pValue.x}
+                y={this.styleOpts.pValue.y}
                 style={baseLabelStyles}
                 textAnchor={this.styleOpts.pValue.textAnchor}
                 text={`Logrank Test P-Value: ${this.pValue}`}
@@ -1406,13 +1403,11 @@ export default class SurvivalChartExtended
                             domain={[0, 100]}
                             crossAxis={false}
                         />
-
+                        {this.showPValueText && this.pValueText}
                         {this.showLegend && this.xAxisForPlot}
                         {!this.showLegend && this.xAxisForSummaryViewPlot}
                         {this.scattersAndLines}
-                        {this.showLegend &&
-                            this.showHazardRatio &&
-                            this.pValueText}
+                        {this.showLegend && this.showHazardRatio}
                         {this.showNormalLegend && this.defaultLegend}
                         {this.showHazardRatio && (
                             <VictoryLegend