Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle more general cases in ONNX.Expand lowering to stablehlo #2747

Merged
merged 10 commits into from
Mar 18, 2024
Merged

Handle more general cases in ONNX.Expand lowering to stablehlo #2747

merged 10 commits into from
Mar 18, 2024

Conversation

srcarroll
Copy link
Contributor

@srcarroll srcarroll commented Mar 8, 2024 •
edited
Loading

Previously the lowering only worked if the defining op of the shape operand was a constant or ONNX.Shape op. It is unnecessary to specialize for the latter, so this patch generalizes it.

@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@srcarroll
Copy link
Contributor Author

@tungld can i get a review on this?

tungld
tungld approved these changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@tungld tungld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@tungld tungld merged commit cd77dd7 into onnx:main Mar 18, 2024
8 checks passed
@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #14386 [push] Handle more general case... started at 04:20

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #13411 [push] Handle more general case... started at 05:29

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #14416 [push] Handle more general case... started at 05:20

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #14386 [push] Handle more general case... passed after 1 hr 3 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #14416 [push] Handle more general case... passed after 1 hr 22 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #13411 [push] Handle more general case... passed after 1 hr 57 min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tungld tungld tungld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srcarroll @jenkins-droid @tungld