Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NNPA] Check element types in rewrite-onnx-for-zhigh pass #2548

Merged
merged 2 commits into from
Oct 4, 2023
Merged

[NNPA] Check element types in rewrite-onnx-for-zhigh pass #2548

merged 2 commits into from
Oct 4, 2023

Conversation

tungld
Copy link
Collaborator

@tungld tungld commented Oct 3, 2023

fixes #2540

@tungld tungld mentioned this pull request Oct 3, 2023
Closed
@chentong319
Copy link
Collaborator

Any way to simplify the condition for DynamicallyLegal determination? Like define some common conditions with a meaningful function?

AlexandreEichenberger
AlexandreEichenberger approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@AlexandreEichenberger AlexandreEichenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix

@tungld
Copy link
Collaborator Author

tungld commented Oct 4, 2023

Any way to simplify the condition for DynamicallyLegal determination? Like define some common conditions with a meaningful function?

A first attempt is PR #2510 that partially simplified DynamicallyLegal a lot so that we can set device with a single pass. We also have common functions like addDynamicallyLegalOpFor to accept a custom lambda function. Some common conditions we have for example isValidElementTypeAndRank, isCompatibleWithNNPALevel

@tungld tungld merged commit 3757344 into onnx:main Oct 4, 2023
8 checks passed
@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #12920 [push] Check element types in r... started at 00:59

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #12896 [push] Check element types in r... started at 23:59

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #11913 [push] Check element types in r... started at 01:07

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #12896 [push] Check element types in r... passed after 1 hr 3 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #12920 [push] Check element types in r... passed after 1 hr 25 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #11913 [push] Check element types in r... passed after 1 hr 53 min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandreEichenberger AlexandreEichenberger AlexandreEichenberger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Int64 ops seems to be placed on NNPA device
4 participants
@tungld @chentong319 @jenkins-droid @AlexandreEichenberger