Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test semgrep check - use node 20 supported actions #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

test semgrep check - use node 20 supported actions #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
523cb45
Update aax.go
onkarvhanumante Feb 7, 2024
420a44d
Update aax.go
onkarvhanumante Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion adapters/aax/aax.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
package aax
//

import (
"encoding/json"
Expand Down Expand Up @@ -88,7 +89,7 @@ func (a *adapter) MakeBids(internalRequest *openrtb2.BidRequest, externalRequest
// Builder builds a new instance of the Aax adapter for the given bidder with the given config.
func Builder(bidderName openrtb_ext.BidderName, config config.Adapter, server config.Server) (adapters.Bidder, error) {
url := buildEndpoint(config.Endpoint, config.ExtraAdapterInfo)
return &adapter{
return &adapterAAX{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can call this simply "adapter", the adapterAAX identification is already supplied by the package name. As you have it, referencing your adapter from outside the package would be adapterAAX.adapterAAX which looks a little redundant. See example below:

  package foo

  type adapter struct {
    endpoint string
  }
  
  func  Builder(bidderName openrtb_ext.BidderName, config config.Adapter, server config.Server) (adapters.Bidder, error) {
    return &adapter{endpoint: "https://www.foo.com"}, nil
  }

endpoint: url,
}, nil
}
Expand Down
Loading