App strings reworked #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comradekingu
commented
Oct 2, 2022
| <string name="share_button_stopping">Stopping… wait until stopped</string> | ||
| <string name="share_button_error">Try again</string> | ||
| <string name="share_button_stopping">Stopping… (Wait till it has stopped.)</string> | ||
| <string name="share_button_error">Retry</string> |
There was a problem hiding this comment.
There is a "Retry" below too…
There was a problem hiding this comment.
Considering the description for it is mentions error, I would expect this to be used in the context of like a title?
(oop, seems like you mention it below)
comradekingu
commented
Oct 2, 2022
| <string name="share_button_start">Start Sharing</string> | ||
| <string name="share_button_starting">Starting… tap to cancel</string> | ||
| <string name="share_button_starting">Starting… Tap to cancel.</string> |
There was a problem hiding this comment.
Suggested change
| <string name="share_button_starting">Starting… Tap to cancel.</string> | |
| <string name="share_button_starting">Starting… (Tap to cancel.)</string> |
comradekingu
commented
Oct 2, 2022
| @@ -13,7 +13,7 @@ | |||
| <string name="remove">Remove</string> | |||
| <string name="share_empty_state">Nothing here yet.</string> | |||
| <string name="warning_alpha_intro">Warning:</string> | |||
| <string name="warning_alpha">This is an early alpha release. It should only be used for testing. The code is not finished and has not been audited.</string> | |||
| <string name="warning_alpha">This early alpha release should only be used for testing. The code is unfinished and not audited.</string> | |||
There was a problem hiding this comment.
Suggested change
| <string name="warning_alpha">This early alpha release should only be used for testing. The code is unfinished and not audited.</string> | |
| <string name="warning_alpha">This early alpha release is only for testing. The code is unfinished and not audited.</string> |
comradekingu
commented
Oct 2, 2022
|
|
||
| <string name="settings_title">Settings</string> | ||
| <string name="settings_tor_title">Connecting to Tor</string> | ||
| <string name="settings_tor_automatic">Automatic based on location</string> | ||
| <string name="settings_tor_intro">A bridge is a dedicated uncensored route into the Tor network. Even if Automatic is selected, OnionShare may try to use bridges to connect.</string> | ||
| <string name="settings_tor_automatic">Automatic, based on location</string> |
There was a problem hiding this comment.
This is not good.
comradekingu
commented
Oct 2, 2022
| <string name="notification_sharing_text">Tap to get the OnionShare address to share your files.</string> | ||
| <string name="starting_notification_title">Publishing…</string> | ||
| <string name="starting_notification_text">(May take a while.)</string> | ||
| <string name="sharing_notification_title">Sharing…</string> | ||
| <string name="share_error_snackbar_text">Could not start OnionShare</string> | ||
| <string name="share_error_file_snackbar_text">Could not open %s. Removed.</string> | ||
| <string name="share_error_snackbar_action">Retry</string> |
There was a problem hiding this comment.
This is the other "Retry". Is one the title and the other is a button?
comradekingu
commented
Oct 2, 2022
| <string name="notification_sharing_text">Tap to get the OnionShare address to share your files.</string> | ||
| <string name="starting_notification_title">Publishing…</string> | ||
| <string name="starting_notification_text">(May take a while.)</string> | ||
| <string name="sharing_notification_title">Sharing…</string> | ||
| <string name="share_error_snackbar_text">Could not start OnionShare</string> | ||
| <string name="share_error_file_snackbar_text">Could not open %s. Removed.</string> |
There was a problem hiding this comment.
Suggested change
| <string name="share_error_file_snackbar_text">Could not open %s. Removed.</string> | |
| <string name="share_error_file_snackbar_text">Could not open %s. (Removed.)</string> |
comradekingu
commented
Apr 20, 2024
| <string name="share_button_stopping">Stopping… wait until stopped</string> | ||
| <string name="share_button_error">Try again</string> | ||
| <string name="share_button_stopping">Stopping… (Wait till it has stopped.)</string> | ||
| <string name="share_button_error">Retry</string> |
There was a problem hiding this comment.
Suggested change
| <string name="share_button_error">Retry</string> | |
| <string name="share_button_error">Retry?</string> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.