code changes to use single nfp.ini file #582
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| thread_pool_size= 10 | ||
| unix_bind_path= /var/run/uds_socket | ||
| max_connections=10 | ||
| nfp_controller_ip_address= 11.0.0.3 |
There was a problem hiding this comment.
Lets fix 172.16.x.x as the address space for svc_mgmt
There was a problem hiding this comment.
it is just some dummy value which installation scripts will modify.
Should I put that as empty instead of any value ?
…nfp to start each module with single ini file
| # Min time to wait on channel to declare its idle. | ||
| idle_min_wait_timeout=0.1 | ||
| #NFP controllers ip address and port | ||
| nfp_controller_ip=172.16.0.3 |
There was a problem hiding this comment.
Don't hardcode. Leave it empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.