separated enterprise code from orchestrator for sharing #550
Conversation
>> Added fix for docker load inside VM >> Added a sleep after docker daemon is started and before invoking docker load inside VM
>> Added support for building VyOS image into devstack script
>> updated the time for VM to bootup to a safe time
>> The vyos image building scritp should be run as sudo/root
| @@ -374,7 +377,7 @@ def post_event_graph(self, event, graph_nodes): | |||
| LOG.debug(message) | |||
| self._manager.process_events([event]) | |||
|
|
|||
| def post_event(self, event): | |||
| def post_event(self, event, target=None): | |||
There was a problem hiding this comment.
What is target here? Does target indicate who should be handling it? There should be a separation between who is posting and who is handling..
There was a problem hiding this comment.
yes, target is which module should be handling the event.
| # is_internal_event=True) | ||
| # LOG.info(_LI("Sharing existing device: %s(device)s for reuse"), | ||
| # {'device': device}) | ||
| # REVISIT(TODO): Removing sharing for cisco live demo |
There was a problem hiding this comment.
Why we are removing this TODO,
If we need to remove this, then remove "if 0" case also.
There was a problem hiding this comment.
This is not required anymore.. yes will remove 'if 0' too.
|
As per my understanding, sharing code gets applicable on top of submitted master/mitaka code. |
|
What about non-hotplug sharing support, that code will be part of sharing module or new driver ? |
| @@ -65,7 +65,7 @@ def events_init(controller, config, device_orchestrator): | |||
| for event in events: | |||
| events_to_register.append( | |||
| Event(id=event, handler=device_orchestrator)) | |||
| controller.register_events(events_to_register) | |||
| controller.register_events(events_to_register, module='device_orchestrator') | |||
There was a problem hiding this comment.
Can we put description of what this is doing ?
…ixed_unittest Mitaka nfp 13 july 2016 fixed unittest
enhanced and fixed db migration
Build image fix
…S_atf_fl_ip_fix floating ip fix in NS
…erialized on servicechain_node, bug: creating multiple service_chain parallely not orking creating multiple vm ,need to fix that
Fixes stale code in docker issue
…13_july Adding advanced mode gate tests.
…nding: creating multiple service chain sharing same vm
VyOS build image fix
…rgence/group-based-policy into mitaka_21st_march_base_sharing_separate
…hub.com/oneconvergence/group-based-policy into mitaka_21st_march_base_sharing_separate
No description provided.