Update news 4.21 #1153
Merged
Update news 4.21 #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvinlu3
reviewed
Sep 13, 2024
Comment on lines
304
to
308
| <PMIDLink pmids="38410486" /> | ||
| <PMIDLink pmids="37012551" /> | ||
| <PMIDLink pmids="26554404" /> | ||
| <PMIDLink pmids="38032104" /> | ||
| <PMIDLink pmids="27483357" /> |
There was a problem hiding this comment.
You can directly pass a comma separated string to pmids
| [ | ||
| '3A', | ||
| 'ALK', | ||
| 'F1174L/C, F1245Y/V, R1275Q/L', |
There was a problem hiding this comment.
Could you verify if this will be converted to alteration page links? If not, we might need to use WithSeparator.
jfkonecn
force-pushed
the
feature/v4.21
branch
from
c1b9b95
to
02baaa6
Compare
calvinlu3
reviewed
Sep 23, 2024
There was a problem hiding this comment.
This file may need updating once we do a refresh tomorrow since we added back an alteration that was deleted by accident.
src/main/webapp/index.html
Outdated
| @@ -15,15 +14,15 @@ | |||
| <meta name="twitter:site" content="@oncokb"> | |||
| <meta name="twitter:title" content="OncoKB™ - MSK's Precision Oncology Knowledge Base"> | |||
| <meta name="twitter:description" content="OncoKB™ is a precision oncology knowledge base developed at Memorial Sloan Kettering Cancer Center that contains biological and clinical information about genomic alterations in cancer."> | |||
| <meta name="twitter:image" content="https://www.oncokb.org/content/images/oncokb_summary.png?20240704"> | |||
| <meta name="twitter:image" content="https://www.oncokb.org/content/images/oncokb_summary.png?20240920"> | |||
There was a problem hiding this comment.
Let's update date before merging
calvinlu3
reviewed
Sep 24, 2024
src/main/webapp/index.html
Outdated
| <meta name="twitter:url" content="https://www.oncokb.org/"> | ||
|
|
||
| <meta property="og:site_name" content="OncoKB™"> | ||
| <meta property="og:type" content="website"> | ||
| <meta property="og:url" content="https://www.oncokb.org/"> | ||
| <meta property="og:title" content="OncoKB™ - MSK's Precision Oncology Knowledge Base"> | ||
| <meta property="og:description" content="OncoKB™ is a precision oncology knowledge base developed at Memorial Sloan Kettering Cancer Center that contains biological and clinical information about genomic alterations in cancer."> | ||
| <meta property="og:image" content="https://www.oncokb.org/content/images/oncokb_summary.png?20240704"> | ||
| <meta property="og:image" content="https://www.oncokb.org/content/images/oncokb_summary.png?20240920"> |
There was a problem hiding this comment.
Not sure if it was initially intended to include the text Power by the clinical expertise...., but lets include that in the screenshot.
calvinlu3
approved these changes
Sep 24, 2024
jfkonecn
added a commit
to jfkonecn/oncokb-public
that referenced
this pull request
Oct 7, 2024
* Update news 4.20 (oncokb#1142) --------- Co-authored-by: Calvin Lu <[email protected]> Co-authored-by: Hongxin <[email protected]> Co-authored-by: oncokb-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/oncokb/oncokb-pipeline/issues/531