Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gh): full Linux arch support #12

Merged

Conversation

ethanholz
Copy link
Contributor

This PR aims to support the entire set of Linux architectures as provided by actions/runner.

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.21%. Comparing base (81c4f29) to head (4cd1a15).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   94.11%   94.21%   +0.10%     
==========================================
  Files           3        3              
  Lines         289      294       +5     
==========================================
+ Hits          272      277       +5     
  Misses         17       17              
Flag Coverage Δ
unittests 94.21% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dwhswenson dwhswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes for what I see as the more standard format for error messages in Python (follow practices in standard library): namely, single-quotes around values.

(I'm not always perfect at remembering to do this, myself, but I do think it makes the messages more readable.)

src/gha_runner/gh.py Outdated Show resolved Hide resolved
src/gha_runner/gh.py Outdated Show resolved Hide resolved
@ethanholz
Copy link
Contributor Author

@dwhswenson this is ready to merge whenever you are.

@dwhswenson
Copy link
Contributor

Merged in main in order to get CodeCov updates, and then forgot to finish the merge here! Merging now.

@dwhswenson dwhswenson merged commit 09a0aa5 into omsf-eco-infra:main Jul 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants