Limited short labels to 190 unicode characters maximum to simplify in…

…dexation.
omeka · Feb 19, 2024 · 3dcde0a · 3dcde0a
1 parent d6ad71b
commit 3dcde0a
Show file tree

Hide file tree

Showing 8 changed files with 46 additions and 12 deletions.
diff --git a/application/data/install/schema.sql b/application/data/install/schema.sql
@@ -2,7 +2,7 @@ SET FOREIGN_KEY_CHECKS = 0;
 CREATE TABLE `api_key` (
   `id` varchar(32) COLLATE utf8mb4_unicode_ci NOT NULL,
   `owner_id` int NOT NULL,
-  `label` varchar(255) COLLATE utf8mb4_unicode_ci NOT NULL,
+  `label` varchar(190) COLLATE utf8mb4_unicode_ci NOT NULL,
   `credential_hash` varchar(60) COLLATE utf8mb4_unicode_ci NOT NULL,
   `last_ip` varbinary(16) DEFAULT NULL COMMENT '(DC2Type:ip_address)',
   `last_accessed` datetime DEFAULT NULL,
@@ -14,7 +14,7 @@ CREATE TABLE `api_key` (
 CREATE TABLE `asset` (
   `id` int NOT NULL AUTO_INCREMENT,
   `owner_id` int DEFAULT NULL,
-  `name` varchar(255) COLLATE utf8mb4_unicode_ci NOT NULL,
+  `name` varchar(190) COLLATE utf8mb4_unicode_ci NOT NULL,
   `media_type` varchar(190) COLLATE utf8mb4_unicode_ci NOT NULL,
   `storage_id` varchar(190) COLLATE utf8mb4_unicode_ci NOT NULL,
   `extension` varchar(190) COLLATE utf8mb4_unicode_ci DEFAULT NULL,
@@ -131,7 +131,7 @@ CREATE TABLE `property` (
   `owner_id` int DEFAULT NULL,
   `vocabulary_id` int NOT NULL,
   `local_name` varchar(190) CHARACTER SET utf8mb4 COLLATE utf8mb4_bin NOT NULL,
-  `label` varchar(255) COLLATE utf8mb4_unicode_ci NOT NULL,
+  `label` varchar(190) COLLATE utf8mb4_unicode_ci NOT NULL,
   `comment` longtext COLLATE utf8mb4_unicode_ci,
   PRIMARY KEY (`id`),
   UNIQUE KEY `UNIQ_8BF21CDEAD0E05F6623C14D5` (`vocabulary_id`,`local_name`),
@@ -168,7 +168,7 @@ CREATE TABLE `resource_class` (
   `owner_id` int DEFAULT NULL,
   `vocabulary_id` int NOT NULL,
   `local_name` varchar(190) CHARACTER SET utf8mb4 COLLATE utf8mb4_bin NOT NULL,
-  `label` varchar(255) COLLATE utf8mb4_unicode_ci NOT NULL,
+  `label` varchar(190) COLLATE utf8mb4_unicode_ci NOT NULL,
   `comment` longtext COLLATE utf8mb4_unicode_ci,
   PRIMARY KEY (`id`),
   UNIQUE KEY `UNIQ_C6F063ADAD0E05F6623C14D5` (`vocabulary_id`,`local_name`),
@@ -199,7 +199,7 @@ CREATE TABLE `resource_template_property` (
   `id` int NOT NULL AUTO_INCREMENT,
   `resource_template_id` int NOT NULL,
   `property_id` int NOT NULL,
-  `alternate_label` varchar(255) COLLATE utf8mb4_unicode_ci DEFAULT NULL,
+  `alternate_label` varchar(190) COLLATE utf8mb4_unicode_ci DEFAULT NULL,
   `alternate_comment` longtext COLLATE utf8mb4_unicode_ci,
   `position` int DEFAULT NULL,
   `data_type` longtext COLLATE utf8mb4_unicode_ci COMMENT '(DC2Type:json_array)',
@@ -379,7 +379,7 @@ CREATE TABLE `vocabulary` (
   `owner_id` int DEFAULT NULL,
   `namespace_uri` varchar(190) COLLATE utf8mb4_unicode_ci NOT NULL,
   `prefix` varchar(190) COLLATE utf8mb4_unicode_ci NOT NULL,
-  `label` varchar(255) COLLATE utf8mb4_unicode_ci NOT NULL,
+  `label` varchar(190) COLLATE utf8mb4_unicode_ci NOT NULL,
   `comment` longtext COLLATE utf8mb4_unicode_ci,
   PRIMARY KEY (`id`),
   UNIQUE KEY `UNIQ_9099C97B9B267FDF` (`namespace_uri`),

diff --git a/application/data/migrations/20240219000002_LimitLabelsTo190Characters.php b/application/data/migrations/20240219000002_LimitLabelsTo190Characters.php
@@ -0,0 +1,34 @@
+<?php declare(strict_types=1);
+
+namespace Omeka\Db\Migrations;
+
+use Doctrine\DBAL\Connection;
+use Omeka\Db\Migration\MigrationInterface;
+
+class LimitLabelsTo190Characters implements MigrationInterface
+{
+    public function up(Connection $conn)
+    {
+        $sql = <<<'SQL'
+ALTER TABLE `api_key`
+CHANGE `label` `label` varchar(190) COLLATE 'utf8mb4_unicode_ci' NOT NULL AFTER `owner_id`;
+
+ALTER TABLE `asset`
+CHANGE `name` `name` varchar(190) COLLATE 'utf8mb4_unicode_ci' NOT NULL AFTER `owner_id`;
+
+ALTER TABLE `property`
+CHANGE `label` `label` varchar(190) COLLATE 'utf8mb4_unicode_ci' NOT NULL AFTER `local_name`;
+
+ALTER TABLE `resource_class`
+CHANGE `label` `label` varchar(190) COLLATE 'utf8mb4_unicode_ci' NOT NULL AFTER `local_name`;
+
+ALTER TABLE `resource_template_property`
+CHANGE `alternate_label` `alternate_label` varchar(190) COLLATE 'utf8mb4_unicode_ci' NULL AFTER `property_id`;
+
+ALTER TABLE `vocabulary`
+CHANGE `label` `label` varchar(190) COLLATE 'utf8mb4_unicode_ci' NOT NULL AFTER `prefix`;
+
+SQL;
+        $conn->executeStatement($sql);
+    }
+}
diff --git a/application/src/Entity/ApiKey.php b/application/src/Entity/ApiKey.php
@@ -31,7 +31,7 @@ class ApiKey extends AbstractEntity
     protected $id;
 
     /**
-     * @Column
+     * @Column(length=190)
      */
     protected $label;
 

diff --git a/application/src/Entity/Asset.php b/application/src/Entity/Asset.php
@@ -20,7 +20,7 @@ class Asset extends AbstractEntity
     protected $owner;
 
     /**
-     * @Column
+     * @Column(length=190)
      */
     protected $name;
 

diff --git a/application/src/Entity/Property.php b/application/src/Entity/Property.php
@@ -44,7 +44,7 @@ class Property extends AbstractEntity
     protected $localName;
 
     /**
-     * @Column
+     * @Column(length=190)
      */
     protected $label;
 

diff --git a/application/src/Entity/ResourceClass.php b/application/src/Entity/ResourceClass.php
@@ -43,7 +43,7 @@ class ResourceClass extends AbstractEntity
     protected $localName;
 
     /**
-     * @Column
+     * @Column(length=190)
      */
     protected $label;
 

diff --git a/application/src/Entity/ResourceTemplateProperty.php b/application/src/Entity/ResourceTemplateProperty.php
@@ -33,7 +33,7 @@ class ResourceTemplateProperty extends AbstractEntity
     protected $property;
 
     /**
-     * @Column(nullable=true)
+     * @Column(nullable=true, length=190)
      */
     protected $alternateLabel;
 

diff --git a/application/src/Entity/Vocabulary.php b/application/src/Entity/Vocabulary.php
@@ -36,7 +36,7 @@ class Vocabulary extends AbstractEntity
     protected $prefix;
 
     /**
-     * @Column
+     * @Column(length=190)
      */
     protected $label;