Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optionally load javascripts using LcnIncludeAssetsBundle #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jfmaeck
Copy link

@jfmaeck jfmaeck commented Aug 24, 2015

Hi @ollietb,

thank your for providing this useful plugin.

From your Readme:

Because the form type template includes javascript, there's not yet a way to bunch it all together at the very bottom of the page, so it is included at the bottom of the field. This means that jquery and the javascript plugin in Resources/public/js needs to be included before the field. I'm not sure of a way around this, but I think it's going to be addressed in a later version of the form framework.

To overcome this limitation in Symfony 2 we at Faibl Locaine.com built the LcnIncludeAssetsBundle. I created this small pull request to optionally enable automatic script loading in projects using the LcnIncludeAssets bundle.

If you like it, feel free to include the changes in your plugin.

Cheers!

Jonas

@nicodemuz
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants