Properly decode uptime from redis (#170)

* Properly decode uptime from redis * Add uptime_in_seconds & start_time_seconds to expected metrics
oliver006 · Jun 25, 2018 · 3150962 · 3150962
1 parent a8c01c5
commit 3150962
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/exporter/redis.go b/exporter/redis.go
@@ -471,7 +471,7 @@ func (e *Exporter) extractInfoMetrics(info, addr string, alias string, scrapes c
 			continue
 		}
 		if fieldKey == "uptime_in_seconds" {
-			if uptime, err := extractVal(fieldValue); err != nil {
+			if uptime, err := strconv.ParseFloat(fieldValue, 64); err == nil {
 				e.metricsMtx.RLock()
 				e.metrics["start_time_seconds"].WithLabelValues(addr, alias).Set(float64(time.Now().Unix()) - uptime)
 				e.metricsMtx.RUnlock()

diff --git a/exporter/redis_test.go b/exporter/redis_test.go
@@ -327,6 +327,8 @@ func TestExporterMetrics(t *testing.T) {
 		"config_maxmemory",  // testing config extraction
 		"config_maxclients", // testing config extraction
 		"slowlog_length",
+		"start_time_seconds",
+		"uptime_in_seconds",
 	}
 
 	for _, k := range wantKeys {