-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] commodity_trading: module for commodity trading #46
base: 17.0
Are you sure you want to change the base?
Conversation
9b5c166
to
298eae1
Compare
2be0640
to
15e9762
Compare
9ae5b11
to
7cab004
Compare
84719fd
to
5a105ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhrs-odoo
Thanks for working on this PR.
Here are some technical comments.
Cheers!
commodity_trading/__manifest__.py
Outdated
'knowledge', | ||
'mrp_account', | ||
'product_expiry', | ||
# 'product_images', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# 'product_images', | |
# 'product_images', |
?
commodity_trading/__manifest__.py
Outdated
'quality_mrp', | ||
'quality_mrp_workorder', | ||
'sale_mrp', | ||
# 'sale_planning', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
commodity_trading/__manifest__.py
Outdated
# 'website_appointment', | ||
# 'website_crm', | ||
# 'website_crm_partner_assign', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If not needed remove it
commodity_trading/__manifest__.py
Outdated
'quality_mrp', | ||
'quality_mrp_workorder', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe quality_mrp_workorder is enough for installing the quality_mrp
<field name="help"> | ||
<![CDATA[ | ||
<p class="o_view_nocontent_smiling_face"> | ||
This is your new action. | ||
</p> | ||
<p>By default, it contains a list and a form view and possibly | ||
other view types depending on the options you chose for your model. | ||
</p> | ||
<p> | ||
You can start customizing these screens by clicking on the Studio | ||
icon on the top right corner (you can also customize this help message there). | ||
</p> | ||
]]> | ||
</field> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<field name="help"> | |
<![CDATA[ | |
<p class="o_view_nocontent_smiling_face"> | |
This is your new action. | |
</p> | |
<p>By default, it contains a list and a form view and possibly | |
other view types depending on the options you chose for your model. | |
</p> | |
<p> | |
You can start customizing these screens by clicking on the Studio | |
icon on the top right corner (you can also customize this help message there). | |
</p> | |
]]> | |
</field> |
<field name="product_id" ref="product_product_1"/> | ||
<field name="order_id" ref="purchase_order_1"/> | ||
<field name="product_qty">125.0</field> | ||
<field name="price_unit">123.0</field> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
price_unit comes should be set in the product. If already set, we need to remove it
<record id="sale_order_1" model="sale.order"> | ||
<field name="partner_id" ref="res_partner_8"/> | ||
</record> | ||
<record id="sale_order_2" model="sale.order"> | ||
<field name="partner_id" ref="res_partner_8"/> | ||
</record> | ||
<record id="sale_order_3" model="sale.order"> | ||
<field name="partner_id" ref="res_partner_8"/> | ||
</record> | ||
<record id="sale_order_4" model="sale.order"> | ||
<field name="partner_id" ref="res_partner_8"/> | ||
</record> | ||
<record id="sale_order_5" model="sale.order"> | ||
<field name="partner_id" ref="res_partner_8"/> | ||
</record> | ||
<record id="sale_order_6" model="sale.order"> | ||
<field name="partner_id" ref="res_partner_8"/> | ||
</record> | ||
<record id="sale_order_7" model="sale.order"> | ||
<field name="partner_id" ref="res_partner_8"/> | ||
</record> | ||
<record id="sale_order_8" model="sale.order"> | ||
<field name="partner_id" ref="res_partner_8"/> | ||
</record> | ||
<record id="sale_order_9" model="sale.order"> | ||
<field name="partner_id" ref="res_partner_8"/> | ||
</record> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add user_id
Also need to correct the indentation
<field name="product_id" ref="product_product_8"/> | ||
<field name="order_id" ref="sale_order_4"/> | ||
<field name="product_uom_qty">27.0</field> | ||
<field name="price_unit">123.0</field> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
price_unit should be configured in product itself.
@@ -0,0 +1,131 @@ | |||
<?xml version='1.0' encoding='UTF-8'?> | |||
<odoo> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<function name="action_done" model="stock.picking.batch"> | ||
<value model="stock.picking.batch" eval="obj().env.ref('commodity_trading.sale_order_5').picking_ids.batch_id.id"/> | ||
</function> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adbdfd1
to
c6d92cc
Compare
Hello @paso-odoo |
Tailored for commodity traders (e.g., soybeans, wheat) with comprehensive functions, including CRM, quality checks, and broker involvement for product quality and commissions. task-3460474
c6d92cc
to
94a85c5
Compare
Tailored for commodity traders (e.g., soybeans, wheat) with comprehensive functions, including CRM, quality checks, and broker involvement for product quality and commissions.
task-3460474