-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saas 17.4 mail message format scju #167
Open
jaeschwa
wants to merge
1
commit into
odoo:18.0
Choose a base branch
from
odoo-dev:saas-17.4-mail-message-format-scju
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeschwa
force-pushed
the
saas-17.4-mail-message-format-scju
branch
3 times, most recently
from
August 19, 2024 08:30
95ff2ca
to
62f38cf
Compare
vava-odoo
requested changes
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks overall good, but noted a few things to improve. Thanks @jaeschwa
vava-odoo
reviewed
Aug 29, 2024
vava-odoo
reviewed
Sep 4, 2024
jaeschwa
force-pushed
the
saas-17.4-mail-message-format-scju
branch
from
September 5, 2024 09:25
8fc17dc
to
5493ae1
Compare
vava-odoo
reviewed
Sep 5, 2024
jaeschwa
force-pushed
the
saas-17.4-mail-message-format-scju
branch
2 times, most recently
from
September 20, 2024 07:00
3a6cda0
to
046cd58
Compare
vava-odoo
force-pushed
the
saas-17.4-mail-message-format-scju
branch
5 times, most recently
from
September 27, 2024 12:57
31fb5bd
to
15a216b
Compare
Added the knowledge tour to all industry modules so when a DB is started a tour pointing to the knowledge app is directly launched. To avoid the maintenance lines of code for these tours, these files are added in the cloc_exclude of the manifest, leading to the automatic creation of ir_model_data entries to exclude the cloc. This change is related to this PR: odoo/odoo@a47de680de14 In all the modules, the message related to the onboarding is improved. task-4056239
vava-odoo
force-pushed
the
saas-17.4-mail-message-format-scju
branch
from
September 27, 2024 18:59
15a216b
to
acac5e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[IMP] *: Improvment of the mail messages
In all the modules improved the message related to the on boarding.
Modified mail messages, fixed redirection, the automatic opening and
the purple dot are not implemented.
Changed the tests accordingly with the new mail message definition.
task-4056239