Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change config to use RPC URL directly. #1488

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Change config to use RPC URL directly. #1488

merged 3 commits into from
Nov 1, 2023

Conversation

calina-c
Copy link
Contributor

Closes #1479.

@calina-c calina-c temporarily deployed to CC_REPORTER_ID October 26, 2023 07:51 — with GitHub Actions Inactive
@calina-c calina-c temporarily deployed to CC_REPORTER_ID October 26, 2023 07:51 — with GitHub Actions Inactive

raise Exception(f"Need to set {network_name.upper()}_RPC_URL env variable.")
NAME_PER_NETWORK = {
1: "mainnet",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should get network name from addresses.json , but we can create another ticket for this

@calina-c calina-c merged commit 8e07749 into main Nov 1, 2023
12 checks passed
@calina-c calina-c deleted the issue-1479-rpc-urls branch November 1, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RPC envvar label shouldn't be specific to the network
2 participants