symmetric encryption fixed (#1542)

--------- Co-authored-by: Călina Cenan <[email protected]>
oceanprotocol · Jun 6, 2024 · 0062545 · 0062545
1 parent ba5e9ce
commit 0062545
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/ocean_lib/ocean/crypto.py b/ocean_lib/ocean/crypto.py
@@ -18,8 +18,8 @@
 def calc_symkey(base_str: str) -> str:
     """Compute a symmetric private key that's a function of the base_str"""
     base_b = base_str.encode("utf-8")  # bytes
-    hash_b = sha256(base_b)
-    symkey_b = b64encode(str(hash_b).encode("ascii"))[:43] + b"="  # bytes
+    hash_b = sha256(base_b).hexdigest()
+    symkey_b = b64encode(hash_b.encode("ascii"))[:43] + b"="  # bytes
     symkey = symkey_b.decode("ascii")
     return symkey
 

diff --git a/ocean_lib/ocean/test/test_crypto.py b/ocean_lib/ocean/test/test_crypto.py
@@ -12,6 +12,8 @@ def test_symkey():
     base_str = "foo"
     symkey = crypto.calc_symkey(base_str)
     assert isinstance(symkey, str)
+    wrong_symkey = crypto.calc_symkey("testwrong")
+    assert wrong_symkey != symkey, "NOK : wrong_sym_key is the same as sym_key"
 
 
 @enforce_types