Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Set NV12 as preferred format for multitrack video encoders #11336

Merged

Conversation

dsaedtler
Copy link
Contributor

@dsaedtler dsaedtler commented Oct 2, 2024

Description

Sets the preferred format for multitrack encoders.

Motivation and Context

Twitch doesn't handle 444 or HDR content properly, and currently stream encoders are already always forced to NV12 (if not HDR):

switch (format) {
case VIDEO_FORMAT_I420:
case VIDEO_FORMAT_NV12:
case VIDEO_FORMAT_I010:
case VIDEO_FORMAT_P010:
break;
default:
obs_encoder_set_preferred_video_format(videoStreaming,
VIDEO_FORMAT_NV12);
}

This has been an issue for people that record 444 locally but still stream to Twitch (or other websites for that matter).

See TEB Discord thread: https://discord.com/channels/1171528364000018442/1286889511225393182

How Has This Been Tested?

Streamed to Twitch, confirmed output is now 420.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@RytoEX RytoEX merged commit 37ab500 into obsproject:master Oct 3, 2024
14 checks passed
@RytoEX RytoEX added this to the OBS Studio 31 milestone Oct 3, 2024
@dsaedtler dsaedtler deleted the rodney/multitrack-force-nv12 branch October 3, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants