-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
obs-qsv11: Fix CBR Spike #10902
obs-qsv11: Fix CBR Spike #10902
Conversation
Even when the new update is available, this code will probably need ifdef'd on the libvpl version, because obs-qsv11 is available on Linux where we do not control the version of libvpl available. On Ubuntu 22.04, which we still support, the version of libvpl available is 2022.1.0 (API 2.6). On Ubuntu 24.04, the version of libvpl available is 2023.3.0 (API 2.9). |
Sounds good. I will add the ifdef when the new version of libvpl is released. |
0a203e9
to
9fab0e9
Compare
f30e148
to
8a8fa0a
Compare
8a8fa0a
to
6adca5d
Compare
Now that #11097 has landed, please rebase this. |
6adca5d
to
053f4ec
Compare
Rebased! |
053f4ec
to
791f957
Compare
ae31293
to
089c018
Compare
0c35c64
to
36e9da5
Compare
36e9da5
to
231b932
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine, though I haven't tested it on hardware that would use the new path (Lunar Lake or newer, except Alder Lake N).
Description
CBR improvement for new Intel platform, the peak bitrate is now down to 120% on average from 200% while keeping same bitrate and quality.
This PR will not build until VPL version has been updated: obsproject/obs-deps#254.
Motivation and Context
This change has been made to decrease the CBR spike on new Intel platforms.
How Has This Been Tested?
new Intel platforms on various driver versions
Types of changes
Checklist: