Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obs-qsv11: Fix CBR Spike #10902

Merged
merged 1 commit into from
Sep 10, 2024
Merged

obs-qsv11: Fix CBR Spike #10902

merged 1 commit into from
Sep 10, 2024

Conversation

thyintel
Copy link
Contributor

@thyintel thyintel commented Jun 20, 2024

Description

CBR improvement for new Intel platform, the peak bitrate is now down to 120% on average from 200% while keeping same bitrate and quality.

This PR will not build until VPL version has been updated: obsproject/obs-deps#254.

Motivation and Context

This change has been made to decrease the CBR spike on new Intel platforms.

How Has This Been Tested?

new Intel platforms on various driver versions

Types of changes

  • Performance enhancement (non-breaking change which improves efficiency)

Checklist:

  • [ x] My code has been run through clang-format.
  • [ x] I have read the contributing document.
  • [ x] My code is not on the master branch.
  • [ x] The code has been tested.
  • [ x] All commit messages are properly formatted and commits squashed where appropriate.
  • [ x] I have included updates to all appropriate documentation.

@WizardCM WizardCM added Bug Fix Non-breaking change which fixes an issue Enhancement Improvement to existing functionality labels Jun 22, 2024
@RytoEX
Copy link
Member

RytoEX commented Jun 26, 2024

This PR will not build until VPL update (predicted by end of this month).

Even when the new update is available, this code will probably need ifdef'd on the libvpl version, because obs-qsv11 is available on Linux where we do not control the version of libvpl available. On Ubuntu 22.04, which we still support, the version of libvpl available is 2022.1.0 (API 2.6). On Ubuntu 24.04, the version of libvpl available is 2023.3.0 (API 2.9).

@thyintel
Copy link
Contributor Author

This PR will not build until VPL update (predicted by end of this month).

Even when the new update is available, this code will probably need ifdef'd on the libvpl version, because obs-qsv11 is available on Linux where we do not control the version of libvpl available. On Ubuntu 22.04, which we still support, the version of libvpl available is 2022.1.0 (API 2.6). On Ubuntu 24.04, the version of libvpl available is 2023.3.0 (API 2.9).

Sounds good. I will add the ifdef when the new version of libvpl is released.

@thyintel thyintel force-pushed the cbr_improvement branch 2 times, most recently from 0a203e9 to 9fab0e9 Compare July 3, 2024 22:45
@RytoEX RytoEX self-assigned this Jul 24, 2024
@thyintel thyintel force-pushed the cbr_improvement branch 4 times, most recently from f30e148 to 8a8fa0a Compare August 1, 2024 20:47
@thyintel thyintel marked this pull request as ready for review August 1, 2024 20:53
@RytoEX
Copy link
Member

RytoEX commented Aug 16, 2024

Now that #11097 has landed, please rebase this.

@thyintel
Copy link
Contributor Author

Now that #11097 has landed, please rebase this.

Rebased!

plugins/obs-qsv11/QSV_Encoder_Internal.cpp Outdated Show resolved Hide resolved
plugins/obs-qsv11/QSV_Encoder_Internal.cpp Outdated Show resolved Hide resolved
plugins/obs-qsv11/QSV_Encoder_Internal.cpp Outdated Show resolved Hide resolved
plugins/obs-qsv11/QSV_Encoder_Internal.cpp Outdated Show resolved Hide resolved
@thyintel thyintel force-pushed the cbr_improvement branch 2 times, most recently from ae31293 to 089c018 Compare August 22, 2024 22:20
@thyintel thyintel force-pushed the cbr_improvement branch 2 times, most recently from 0c35c64 to 36e9da5 Compare August 27, 2024 18:45
Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, though I haven't tested it on hardware that would use the new path (Lunar Lake or newer, except Alder Lake N).

@RytoEX RytoEX merged commit 9f4f2e9 into obsproject:master Sep 10, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue Enhancement Improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants