Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial: Add version requirement for nlohmann/json #452

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stephematician
Copy link

Description

Adds a version requirement for nlohmann/json to find_package call in CMakeLists.txt.

Motivation and Context

obs-browser requires nlohmann/json >= 3.11 due to the use of *_WITH_DEFAULT macros, which are not defined in earlier versions.

How Has This Been Tested?

Tested on UbuntuMATE 22.04, g++12.

  • nlohmann/json built and installed from source;
  • used backport of ffmpeg 6 from ppa.

Types of changes

Build improvement: Makes it easier to identify problems when nlohmann < 3.11 installed - likely not critical as e.g. linux distros with ffmpeg6 in APT almost always have nlohmann >= 3.11; but 22.04 (for example) does not.

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Need >= 3.11 for *_WITH_DEFAULT macros
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant