-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #53
Conversation
package.json
Outdated
"react-native-render-html": "^6.3.4", | ||
"react-test-renderer": "18.2.0", | ||
"ts-jest": "^29.2.2", | ||
"react-test-renderer": "18.3.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Volgens npx @rnx-kit/align-deps --requirements [email protected]
:
- react-test-renderer "18.3.1" should be "18.2.0"
@jonathan-waarneming-nl Deze branch geeft een issue in de Observation app. Als ik daar deze branch in |
Volgens mij komt dat door de verschillende versies van @FortAwesome packages. Als er verschillen zijn zet ie de versies die nodig zijn in de Als de versies hetzelfde zijn is 't probleem weg. Je zou de dependencies Of deze branch gebruiken in https://github.com/observation/app/pull/499 en mergen, dan heb worden steeds dezelfde versies gebruikt. Volgens mij kun je jest ook instellen die de node_modules van dit packages niet worden getranspiled. |
Okay, thanks, ik heb in de overeenkomstige PR voor de observation app de font awesome dependencies verwijderd. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Contributes to: https://github.com/observation/app/issues/484
Also: fix for lint ignore that was accidentally removed