-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding trophic relations for issue 647 #737
Conversation
Hi @diatomsRcool, are you using Protégé to create new terms? Could you please update the annotations to use the one from This is the reason the QC is failing. Let me know if you need help updating the annotations locally. |
having trouble with protege.....not sure if this worked |
ok, fixed - I think |
It's good. All QC passed! Thanks, @diatomsRcool |
@anitacaron Do you want to update the branch? It says it is out of date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can merge once example is added as per @cthoyt's request
This PR has not seen any activity in 90 days and has been marked as stale. If it is no longer needed, please close the PR. Otherwise, please update the PR with a status update. |
@anitacaron to resolve conversations, approve, and merge pull request. |
…nto thessen-3 test wq:wq lkjq :q :wq
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically approved. Still need to have an ontology review.
This PR has not seen any activity in 90 days and has been marked as stale. If it is no longer needed, please close the PR. Otherwise, please update the PR with a status update. |
I've added "symbiotrophically interacts with" and "trophic parasite of" as mentioned in #647 . I'm a little concerned about collisions with "acquires nutrients from". Also shouldn't all the "eats" and "is eaten by" be filed away under the "acquires nutrients from" and "provides nutrients for"?