Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding trophic relations for issue 647 #737

Merged
merged 15 commits into from
Aug 12, 2024
Merged

adding trophic relations for issue 647 #737

merged 15 commits into from
Aug 12, 2024

Conversation

diatomsRcool
Copy link
Contributor

I've added "symbiotrophically interacts with" and "trophic parasite of" as mentioned in #647 . I'm a little concerned about collisions with "acquires nutrients from". Also shouldn't all the "eats" and "is eaten by" be filed away under the "acquires nutrients from" and "provides nutrients for"?

@anitacaron
Copy link
Collaborator

Hi @diatomsRcool, are you using Protégé to create new terms?

Could you please update the annotations to use the one from dc-terms http://purl.org/dc/terms/ instead of dc-elements http://purl.org/dc/elements/1.1/?

This is the reason the QC is failing.

Let me know if you need help updating the annotations locally.

@diatomsRcool
Copy link
Contributor Author

having trouble with protege.....not sure if this worked

@diatomsRcool
Copy link
Contributor Author

ok, fixed - I think

@anitacaron
Copy link
Collaborator

It's good. All QC passed! Thanks, @diatomsRcool

@wdduncan
Copy link
Collaborator

@anitacaron Do you want to update the branch? It says it is out of date.

@anitacaron anitacaron self-requested a review as a code owner August 14, 2023 15:05
@anitacaron anitacaron linked an issue Aug 14, 2023 that may be closed by this pull request
@cmungall cmungall changed the title adding relations for issue 647 adding trophic relations for issue 647 Aug 14, 2023
cmungall
cmungall previously approved these changes Aug 14, 2023
Copy link
Contributor

@cmungall cmungall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can merge once example is added as per @cthoyt's request

wdduncan
wdduncan previously approved these changes Aug 14, 2023
Copy link
Contributor

This PR has not seen any activity in 90 days and has been marked as stale. If it is no longer needed, please close the PR. Otherwise, please update the PR with a status update.

@github-actions github-actions bot added the stale label Nov 15, 2023
@diatomsRcool diatomsRcool dismissed stale reviews from wdduncan and cmungall via 07defcc March 25, 2024 15:44
src/ontology/ro-edit.owl Outdated Show resolved Hide resolved
@jhpoelen
Copy link
Contributor

@anitacaron to resolve conversations, approve, and merge pull request.

src/ontology/ro-edit.owl Show resolved Hide resolved
src/ontology/ro-edit.owl Show resolved Hide resolved
@github-actions github-actions bot removed the stale label Mar 26, 2024
Copy link
Collaborator

@anitacaron anitacaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically approved. Still need to have an ontology review.

Copy link
Contributor

This PR has not seen any activity in 90 days and has been marked as stale. If it is no longer needed, please close the PR. Otherwise, please update the PR with a status update.

@github-actions github-actions bot added the stale label Jun 27, 2024
@github-actions github-actions bot removed the stale label Jul 16, 2024
@anitacaron anitacaron merged commit b708144 into master Aug 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NTR : symbiotrophically interacts with
6 participants