Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OAK matching to uPheno 2 #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add OAK matching to uPheno 2 #43

wants to merge 1 commit into from

Conversation

matentzn
Copy link
Contributor

@matentzn matentzn commented Nov 7, 2022

robot filter -i upheno.owl --term http://purl.obolibrary.org/obo/UPHENO_0001001 --select "self descendants" -o upheno-minimal.owl

@hrshdhgd
Copy link

@matentzn , I may need a upheno.sssom.config.yml file for the mapping, correct?

@matentzn
Copy link
Contributor Author

For which part exactly?

@hrshdhgd
Copy link

hrshdhgd commented Nov 17, 2022

filtering prefixes. Do we need to do that? Similar to this.

@matentzn
Copy link
Contributor Author

Yes, better.. There is sooo much noise we don't care about in uPheno!

@hrshdhgd
Copy link

Where do I grab that from? Or does that need to be curated?

@matentzn
Copy link
Contributor Author

No great file atm, but you can search this file https://github.com/obophenotype/upheno-dev/blob/master/src/curation/upheno-config.yaml for prefix_iri to get a good starting point!

@hrshdhgd
Copy link

hrshdhgd commented Nov 18, 2022

Ok, the robot code generates the upheno-minimal.owl file but after running oaklib, there aren't any mappings generated. So I used the entire file to generate the mappings and the results look promising. This takes around 22 mins.

@hrshdhgd hrshdhgd mentioned this pull request Nov 18, 2022
3 tasks
@cmungall
Copy link
Member

for this not to produce false positives like

DDPHENO:0000004 decreased migratory slug size (DDPHENO) skos:exactMatch DDPHENO:0000379 decreased vegetative cell size (DDPHENO) semapv:LexicalMatching oaklib 0.9411764705882353 oio:hasDbXref oio:hasDbXref pmid:18366659

we need the phenotype ontologies to follow standards and not use pmids as class xrefs

this may take a while to percolate, so should we filter at the robot level or the oak level?

@hrshdhgd
Copy link

hrshdhgd commented Nov 18, 2022

I opened a parallel PR by accident. Sorry Nico!

@matentzn
Copy link
Contributor Author

@cmungall i am happy to lead a push on cleaning out these xrefs, but first we need to answer this: information-artifact-ontology/ontology-metadata#94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants